Implement redirect handling on MojoAsyncResourceHandler

content/browser/loader/mojo_async_resource_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_LOADER_MOJO_ASYNC_RESOURCE_HANDLER_H_
 #define CONTENT_BROWSER_LOADER_MOJO_ASYNC_RESOURCE_HANDLER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 15 matching lines @@
 }
 
 namespace content {
 class ResourceDispatcherHostImpl;
 struct ResourceResponse;
 
 // Used to complete an asynchronous resource request in response to resource
 // load events from the resource dispatcher host. This class is used only
 // when LoadingWithMojo runtime flag is enabled.
 //
-// TODO(yhirano): Implement redirects.
 // TODO(yhirano): Add histograms.
-// TODO(yhirano): Set zoom level.
 // TODO(yhirano): Send cached metadata.
 //
 // This class can be inherited only for tests.
 class CONTENT_EXPORT MojoAsyncResourceHandler
     : public ResourceHandler,
       public NON_EXPORTED_BASE(mojom::URLLoader) {
  public:
   MojoAsyncResourceHandler(
       net::URLRequest* request,
       ResourceDispatcherHostImpl* rdh,
@@ skipping 11 matching lines @@
                   int* buf_size,
                   int min_size) override;
   bool OnReadCompleted(int bytes_read, bool* defer) override;
   void OnResponseCompleted(const net::URLRequestStatus& status,
                            bool* defer) override;
   void OnDataDownloaded(int bytes_downloaded) override;
 
   // mojom::URLLoader implementation
   void FollowRedirect() override;
 
-  void ResumeForTesting();
+  void OnWritableForTesting();
   static void SetAllocationSizeForTesting(size_t size);
   static constexpr size_t kDefaultAllocationSize = 512 * 1024;
 
  protected:
   // These functions can be overriden only for tests.
   virtual MojoResult BeginWrite(void** data, uint32_t* available);
   virtual MojoResult EndWrite(uint32_t written);
 
  private:
   class SharedWriter;
   class WriterIOBuffer;
 
   // This funcion copies data stored in |buffer_| to |shared_writer_| and
   // resets |buffer_| to a WriterIOBuffer when all bytes are copied. Returns
   // true when done successfully.
   bool CopyReadDataToDataPipe(bool* defer);
   // Allocates a WriterIOBuffer and set it to |*buf|. Returns true when done
   // successfully.
   bool AllocateWriterIOBuffer(scoped_refptr<net::IOBufferWithSize>* buf,
                               bool* defer);
 
   void Resume();

[mmenke, 2016/11/10 21:42:40]

This method no longer exists.

[yhirano, 2016/11/11 09:47:04]

Done.

   void OnDefer();
   bool CheckForSufficientResource();
   void OnWritable(MojoResult result);
   void Cancel();
 
   ResourceDispatcherHostImpl* rdh_;
   mojo::AssociatedBinding<mojom::URLLoader> binding_;
 
   bool has_checked_for_sufficient_resources_ = false;
   bool sent_received_response_message_ = false;
   bool is_using_io_buffer_not_from_writer_ = false;
   bool did_defer_ = false;
   base::TimeTicks response_started_ticks_;
   int64_t reported_total_received_bytes_ = 0;
 
   mojo::Watcher handle_watcher_;
   std::unique_ptr<mojom::URLLoader> url_loader_;
   mojom::URLLoaderClientAssociatedPtr url_loader_client_;
   scoped_refptr<net::IOBufferWithSize> buffer_;
   size_t buffer_offset_ = 0;
   size_t buffer_bytes_read_ = 0;
   scoped_refptr<SharedWriter> shared_writer_;
 
   DISALLOW_COPY_AND_ASSIGN(MojoAsyncResourceHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_LOADER_MOJO_ASYNC_RESOURCE_HANDLER_H_