Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 246783003: Remove enum types which are duplicated and cause error on webkit style checker. (Closed)

Created:
6 years, 8 months ago by KhNo
Modified:
6 years, 8 months ago
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove enum types which are duplicated and cause error on webkit style checker. DistanceModel and PanningModel emuns are duplicated with distance and panner. It doesn't need to be declared in pannerNode. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172167

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add ASSERT_NOT_REACHED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M Source/modules/webaudio/PannerNode.h View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 1 5 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
KhNo
Please review this patch.
6 years, 8 months ago (2014-04-22 14:27:47 UTC) #1
Raymond Toy
Nice! lgtm with a nit. https://codereview.chromium.org/246783003/diff/1/Source/modules/webaudio/PannerNode.cpp File Source/modules/webaudio/PannerNode.cpp (right): https://codereview.chromium.org/246783003/diff/1/Source/modules/webaudio/PannerNode.cpp#newcode222 Source/modules/webaudio/PannerNode.cpp:222: return false; Might be ...
6 years, 8 months ago (2014-04-22 16:54:41 UTC) #2
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-22 17:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/246783003/20001
6 years, 8 months ago (2014-04-22 17:08:39 UTC) #4
KhNo
On 2014/04/22 16:54:41, Raymond Toy wrote: > Nice! > > lgtm with a nit. > ...
6 years, 8 months ago (2014-04-22 17:08:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 17:58:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-22 17:58:27 UTC) #7
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-22 20:10:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/246783003/20001
6 years, 8 months ago (2014-04-22 20:10:59 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 20:12:08 UTC) #10
Message was sent while issue was closed.
Change committed as 172167

Powered by Google App Engine
This is Rietveld 408576698