Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2467803005: [telemetry] Always use a dynamic device port on android. (RELAND) (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : original #

Patch Set 2 : fixed #

Total comments: 2

Patch Set 3 : nednguyen comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 1 month ago (2016-11-03 13:27:49 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/2467803005/diff/20001/telemetry/telemetry/internal/platform/android_platform_backend.py File telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/2467803005/diff/20001/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode46 telemetry/telemetry/internal/platform/android_platform_backend.py:46: try: Can you add comment why we need ...
4 years, 1 month ago (2016-11-03 13:31:46 UTC) #3
jbudorick
https://codereview.chromium.org/2467803005/diff/20001/telemetry/telemetry/internal/platform/android_platform_backend.py File telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/2467803005/diff/20001/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode46 telemetry/telemetry/internal/platform/android_platform_backend.py:46: try: On 2016/11/03 13:31:46, nednguyen wrote: > Can you ...
4 years, 1 month ago (2016-11-03 13:38:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467803005/40001
4 years, 1 month ago (2016-11-03 13:38:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5e736f42a1a9e45f7063fae7a713ff904831f55f
4 years, 1 month ago (2016-11-03 13:57:54 UTC) #9
jbudorick
4 years, 1 month ago (2016-11-03 18:50:27 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2474943003/ by jbudorick@chromium.org.

The reason for reverting is: Speculative: may be breaking the catapult roll
again..

Powered by Google App Engine
This is Rietveld 408576698