Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467793002: use scoped_refptr

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, shimazu+serviceworker_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), nhiroki, kinuko+serviceworker, darin-cc_chromium.org, blink-worker-reviews_chromium.org, loading-reviews_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use scoped_refptr CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -79 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 15 chunks +113 lines, -34 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_navigation_handle.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_navigation_handle.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_navigation_handle_core.h View 2 chunks +10 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_navigation_handle_core.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
horo
Description was changed from ========== use scoped_refptr ========== to ========== use scoped_refptr CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
4 years, 1 month ago (2016-11-01 08:15:12 UTC) #1
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 04:00:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467793002/20001
4 years, 1 month ago (2016-11-02 04:00:24 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 05:06:20 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isolation/builds/4419)
4 years, 1 month ago (2016-11-02 05:06:21 UTC) #5
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 07:53:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467793002/40001
4 years, 1 month ago (2016-11-02 07:53:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 08:51:13 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 08:51:14 UTC) #9 
Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

Powered by Google App Engine
This is Rietveld 408576698