Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: ui/login/account_picker/screen_account_picker.js

Issue 2467783002: ChromeOS: update alignment of user POD error bubble. (Closed)
Patch Set: Removed some debug Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/login/bubble.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/screen_account_picker.js
diff --git a/ui/login/account_picker/screen_account_picker.js b/ui/login/account_picker/screen_account_picker.js
index b70d43e440d1dde35048862979fbf1b9a82a59c2..8d2acc963beacc7ad72318eb5a024f92a11bde10 100644
--- a/ui/login/account_picker/screen_account_picker.js
+++ b/ui/login/account_picker/screen_account_picker.js
@@ -180,16 +180,11 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
// Update the pod row display if incorrect password.
$('pod-row').setFocusedPodErrorDisplay(true);
// We want bubble's arrow to point to the first letter of input.
- /** @const */ var BUBBLE_OFFSET = 7;
- /** @const */ var BUBBLE_PADDING = 4;
+ /** @const */ var BUBBLE_OFFSET = 0;
+ /** @const */ var BUBBLE_PADDING = -6;
- // Anchor the bubble to the pod instead of the input if the pin keyboard
- // is showing to avoid covering parts of the pin keyboard.
- var bubbleAnchor;
- if (activatedPod.pinContainer)
- bubbleAnchor = activatedPod;
- else
- bubbleAnchor = activatedPod.mainInput;
+ // Anchor the bubble to the pod instead of the input.
+ var bubbleAnchor = activatedPod;
jdufault 2016/11/01 15:32:52 This works as expected when PIN is enabled? PIN g
// We want the bubble to point to where the input is after it is done
// transitioning.
@@ -199,7 +194,8 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
$('bubble').showContentForElement(bubbleAnchor,
cr.ui.Bubble.Attachment.BOTTOM,
error,
- BUBBLE_OFFSET, BUBBLE_PADDING);
+ BUBBLE_OFFSET, BUBBLE_PADDING,
+ true);
};
activatedPod.addEventListener("webkitTransitionEnd",
showBottomCallback);
« no previous file with comments | « no previous file | ui/login/bubble.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698