ChromeOS: update alignment of user POD error bubble.

ui/login/bubble.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Bubble implementation.
  */
 
 // TODO(xiyuan): Move this into shared.
 cr.define('cr.ui', function() {
@@ skipping 129 matching lines @@
      *     If not specified, bubble element content is shown.
      * @private
      */
     showContentAt_: function(pos, opt_content) {
       this.style.top = this.style.left = this.style.right = this.style.bottom =
           'auto';
       for (var k in pos) {
         if (typeof pos[k] == 'number')
           this.style[k] = pos[k] + 'px';
       }
-      if (opt_content !== undefined) {
-        this.innerHTML = '';
-        this.appendChild(opt_content);
-      }
+      if (opt_content !== undefined)
+        this.replaceContent(opt_content);
+
       this.hidden = false;
       this.classList.remove('faded');
     },
 
     /**
+     * Replaces error message content with the given DOM element.
+     * @param {HTMLElement} content Content to show in bubble.
+     */
+    replaceContent: function(content) {
+      this.innerHTML = '';
+      this.appendChild(content);
+    },
+
+    /**
      * Shows the bubble for given anchor element. Bubble content is not cleared.
      * @param {!HTMLElement} el Anchor element of the bubble.
      * @param {!Attachment} attachment Bubble attachment (on which side of the
      *     element it should be displayed).
      * @param {number=} opt_offset Offset of the bubble.
      * @param {number=} opt_padding Optional padding of the bubble.
      */
     showForElement: function(el, attachment, opt_offset, opt_padding) {
       this.showContentForElement(
           el, attachment, undefined, opt_offset, opt_padding);
     },
 
     /**
      * Shows the bubble for given anchor element.
      * @param {!HTMLElement} el Anchor element of the bubble.
      * @param {!Attachment} attachment Bubble attachment (on which side of the
      *     element it should be displayed).
      * @param {HTMLElement} opt_content Content to show in bubble.
      *     If not specified, bubble element content is shown.
      * @param {number=} opt_offset Offset of the bubble attachment point from
      *     left (for vertical attachment) or top (for horizontal attachment)
      *     side of the element. If not specified, the bubble is positioned to
      *     be aligned with the left/top side of the element but not farther than
      *     half of its width/height.
      * @param {number=} opt_padding Optional padding of the bubble.
      */
     showContentForElement: function(el, attachment, opt_content,
-                                    opt_offset, opt_padding) {
+                                    opt_offset, opt_padding, opt_match_width) {
       /** @const */ var ARROW_OFFSET = 25;
       /** @const */ var DEFAULT_PADDING = 18;
 
       if (opt_padding == undefined)
         opt_padding = DEFAULT_PADDING;
       opt_padding += 10;
 
       var origin = cr.ui.login.DisplayManager.getPosition(el);
       var offset = opt_offset == undefined ?
           [Math.min(ARROW_OFFSET, el.offsetWidth / 2),
@@ skipping 33 matching lines @@
           case Bubble.Attachment.BOTTOM:
             pos.left = origin.left + offset[0] - ARROW_OFFSET;
             pos.top = origin.top + el.offsetHeight + opt_padding;
             break;
           case Bubble.Attachment.LEFT:
             pos.top = origin.top + offset[1] - ARROW_OFFSET;
             pos.right = origin.right + el.offsetWidth + opt_padding;
             break;
         }
       }
+      this.style.width = '';
+      this.removeAttribute('match-width');
+      if (opt_match_width) {

[xiyuan, 2016/11/02 16:17:22]

Would does match_width mean when bubble is on the left/right side of the anchor
element? Do we still need to match width? Or should we match height? Or do
nothing?

[Alexander Alekseev, 2016/11/03 01:27:43]

From design mocks I guess that yes, we should use the same width.

+        this.setAttribute('match-width', '');
+        var el_width =

[xiyuan, 2016/11/02 16:17:21]

el_width -> elWidth, JS uses lowerThenCamelCase style

[Alexander Alekseev, 2016/11/03 01:27:43]

Done.

+            window.getComputedStyle(el, null).getPropertyValue('width');
+        var padding_left = parseInt(window.getComputedStyle(this, null)

[xiyuan, 2016/11/02 16:17:22]

padding_left -> paddingLeft

[Alexander Alekseev, 2016/11/03 01:27:43]

Done.

+            .getPropertyValue('padding-left'));
+        var padding_right = parseInt(window.getComputedStyle(this, null)

[xiyuan, 2016/11/02 16:17:21]

padding_right -> paddingRight

[Alexander Alekseev, 2016/11/03 01:27:43]

Done.

+            .getPropertyValue('padding-right'));
+        if (el_width)
+          this.style.width =
+              (parseInt(el_width) - padding_left - padding_right) + 'px';
+      }
 
       this.anchor_ = el;
       this.showContentAt_(pos, opt_content);
     },
 
     /**
      * Shows the bubble for given anchor element.
      * @param {!HTMLElement} el Anchor element of the bubble.
      * @param {string} text Text content to show in bubble.
      * @param {!Attachment} attachment Bubble attachment (on which side of the
@@ skipping 102 matching lines @@
     handleWindowBlur_: function(e) {
       if (!this.hidden)
         this.hide();
     }
   };
 
   return {
     Bubble: Bubble
   };
 });