Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/password_manager/content/browser/visible_password_observer.cc

Issue 2467773002: Notify SSLManager when all password fields on a page are gone (Closed)
Patch Set: tweak SSLManager comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/visible_password_observer.cc
diff --git a/components/password_manager/content/browser/visible_password_observer.cc b/components/password_manager/content/browser/visible_password_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9f9210b37e24501fde8618a3af96d8c71c12ace7
--- /dev/null
+++ b/components/password_manager/content/browser/visible_password_observer.cc
@@ -0,0 +1,58 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/password_manager/content/browser/visible_password_observer.h"
+
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/common/origin_util.h"
+
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(password_manager::VisiblePasswordObserver);
+
+namespace password_manager {
+
+VisiblePasswordObserver::~VisiblePasswordObserver() {}
+
+void VisiblePasswordObserver::RenderFrameHasVisiblePasswordField(
+ content::RenderFrameHost* render_frame_host) {
+ frame_tree_nodes_with_visible_password_fields_.insert(
+ render_frame_host->GetFrameTreeNodeId());
+ MaybeNotifyPasswordInputShownOnHttp();
+}
+
+void VisiblePasswordObserver::RenderFrameHasNoVisiblePasswordFields(
+ content::RenderFrameHost* render_frame_host) {
+ frame_tree_nodes_with_visible_password_fields_.erase(
+ render_frame_host->GetFrameTreeNodeId());
+ MaybeNotifyAllFieldsInvisible();
+}
+
+void VisiblePasswordObserver::RenderFrameDeleted(
+ content::RenderFrameHost* render_frame_host) {
+ // If a renderer process crashes, it won't send notifications that
+ // the password fields have been hidden, so watch for crashing
+ // processes and remove them from
+ // |frame_tree_nodes_with_visible_password_fields_|.
+ frame_tree_nodes_with_visible_password_fields_.erase(
+ render_frame_host->GetFrameTreeNodeId());
+ MaybeNotifyAllFieldsInvisible();
+}
+
+VisiblePasswordObserver::VisiblePasswordObserver(
+ content::WebContents* web_contents)
+ : content::WebContentsObserver(web_contents), web_contents_(web_contents) {}
+
+void VisiblePasswordObserver::MaybeNotifyPasswordInputShownOnHttp() {
+ if (!content::IsOriginSecure(web_contents_->GetVisibleURL())) {
+ web_contents_->OnPasswordInputShownOnHttp();
+ }
+}
+
+void VisiblePasswordObserver::MaybeNotifyAllFieldsInvisible() {
+ if (frame_tree_nodes_with_visible_password_fields_.empty() &&
+ !content::IsOriginSecure(web_contents_->GetVisibleURL())) {
+ web_contents_->OnAllPasswordInputsHiddenOnHttp();
+ }
+}
+
+} // namespace password_manager
« no previous file with comments | « components/password_manager/content/browser/visible_password_observer.h ('k') | content/browser/ssl/ssl_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698