Add setBatteryListener into Platform.

Add setBatteryStatusListener into Platform.

BUG=122593
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172419

[Srini, 2014-04-23 06:51:35]

Hi,

This patch adds setBatteryListener into Platform so that it can be implemented
in Chromium in the next set of patches. 

Thanks,
-Srini.

[timvolodine, 2014-04-23 17:32:36]

https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
public/platform/Platform.h:39: #include "WebBatteryListener.h"
no need for include if you are forward-declaring it below.

https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
public/platform/Platform.h:59: class WebBatteryListener;
could we rename this to WebBatteryStatusListener? sounds more consistent to me.

https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
public/platform/Platform.h:164: // Battery
-----------------------------------------------------------------
seems that other lines have length 72.. don't know why actually.

https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
public/platform/Platform.h:167: virtual void
setBatteryListener(blink::WebBatteryListener*) { }
can we rename the method to setBatteryStatusListener, I think it'd be more
consistent.

[Srini, 2014-04-23 17:47:32]

On 2014/04/23 17:32:36, timvolodine wrote:
> https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h
> File public/platform/Platform.h (right):
> 
>
https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
> public/platform/Platform.h:39: #include "WebBatteryListener.h"
> no need for include if you are forward-declaring it below.
> 
>
https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
> public/platform/Platform.h:59: class WebBatteryListener;
> could we rename this to WebBatteryStatusListener? sounds more consistent to
me.
> 
>
https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
> public/platform/Platform.h:164: // Battery
> -----------------------------------------------------------------
> seems that other lines have length 72.. don't know why actually.
> 
>
https://codereview.chromium.org/246773007/diff/1/public/platform/Platform.h#n...
> public/platform/Platform.h:167: virtual void
> setBatteryListener(blink::WebBatteryListener*) { }
> can we rename the method to setBatteryStatusListener, I think it'd be more
> consistent.

Thanks for your review Tim. Just fixed all the comments and uploaded the latest
patch.

[timvolodine, 2014-04-23 17:50:04]

lgtm

thanks!

[Srini, 2014-04-23 19:19:10]

On 2014/04/23 17:50:04, timvolodine wrote:
> lgtm
> 
> thanks!

I assume I'd need an approval for abarth too. 

Abarth: Can you check it and give me an approval? Thanks!

-Srini.

[abarth-chromium, 2014-04-23 20:17:38]

lgtm

https://codereview.chromium.org/246773007/diff/20001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/246773007/diff/20001/public/platform/Platform...
public/platform/Platform.h:167: 
Two blank lines between sections pls.

[Srini, 2014-04-23 20:18:39]

On 2014/04/23 20:17:38, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/246773007/diff/20001/public/platform/Platform.h
> File public/platform/Platform.h (right):
> 
>
https://codereview.chromium.org/246773007/diff/20001/public/platform/Platform...
> public/platform/Platform.h:167: 
> Two blank lines between sections pls.

Sure, I'll add them. Thanks abarth.

[Srini, 2014-04-23 20:38:41]

The CQ bit was checked by srinivasa.ragavan.venkateswaran@intel.com

[commit-bot: I haz the power, 2014-04-23 20:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/srinivasa.ragavan.venkateswaran@intel....

[commit-bot: I haz the power, 2014-04-23 21:44:05]

Change committed as 172419