third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm - Issue 2467693002: Implement overlay scrollbar fade out for non-composited scrollers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

Issue 2467693002: Implement overlay scrollbar fade out for non-composited scrollers. (Closed)

Patch Set: overlay-scrollbar-mouse-capture now works on Mac Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

index 60d97556f4c6f11a0934be919c53a2d87cbd020b..e2030e0b02818d6eef0a96ddd4208e15d891bf18 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

@@ -92,10 +92,7 @@ using namespace blink;

context:(void*)context {

if ([keyPath isEqualToString:@"knobAlpha"]) {

BOOL visible = [_scrollbarPainter.get() knobAlpha] > 0;

- if (_visible != visible) {

- _visible = visible;

- _scrollbar->visibilityChanged();

- }

+ _scrollbar->setScrollbarsHidden(!visible);

dtapuska 2016/11/02 16:53:21 Can we remove the _visible member now?

bokan 2016/11/02 22:41:57 Done.

}