Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2467693002: Implement overlay scrollbar fade out for non-composited scrollers. (Closed)
Patch Set: overlay-scrollbar-mouse-capture now works on Mac Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index 30c217d4ed09101fd51363470204871914f1f04d..20fc84283041301fba58c72d571d96fa1843572e 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -170,7 +170,7 @@ void PaintLayerScrollableArea::dispose() {
if (m_resizer)
m_resizer->destroy();
- clearScrollAnimators();
+ clearScrollableArea();
// Note: it is not safe to call ScrollAnchor::clear if the document is being
// destroyed, because LayoutObjectChildList::removeChildNode skips the call to
@@ -366,6 +366,7 @@ void PaintLayerScrollableArea::updateScrollOffset(const ScrollOffset& newOffset,
if (scrollOffset() == newOffset)
return;
+ showOverlayScrollbars();
ScrollOffset scrollDelta = scrollOffset() - newOffset;
m_scrollOffset = newOffset;
@@ -515,6 +516,10 @@ IntRect PaintLayerScrollableArea::visibleContentRect(
max(0, layer()->size().height() - horizontalScrollbarHeight)));
}
+void PaintLayerScrollableArea::visibleContentResized() {
+ showOverlayScrollbars();
+}
+
int PaintLayerScrollableArea::visibleHeight() const {
return layer()->size().height();
}
@@ -546,6 +551,7 @@ bool PaintLayerScrollableArea::shouldSuspendScrollAnimations() const {
}
void PaintLayerScrollableArea::scrollbarVisibilityChanged() {
+ updateScrollbarsEnabledState();
if (LayoutView* view = box().view())
return view->clearHitTestCache();
}
@@ -642,6 +648,8 @@ void PaintLayerScrollableArea::updateScrollOrigin() {
}
void PaintLayerScrollableArea::updateScrollDimensions() {
+ if (m_overflowRect.size() != box().layoutOverflowRect().size())
+ contentsResized();
m_overflowRect = box().layoutOverflowRect();
box().flipForWritingMode(m_overflowRect);
updateScrollOrigin();
@@ -654,10 +662,6 @@ void PaintLayerScrollableArea::setScrollOffsetUnconditionally(
scrollOffsetChanged(offset, scrollType);
}
-void PaintLayerScrollableArea::didChangeScrollbarsHidden() {
- updateScrollbarsEnabledState();
-}
-
void PaintLayerScrollableArea::updateScrollbarsEnabledState() {
// overflow:scroll should just enable/disable.
if (box().style()->overflowX() == OverflowScroll && horizontalScrollbar()) {

Powered by Google App Engine
This is Rietveld 408576698