Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/public/platform/WebThemeEngine.h

Issue 2467693002: Implement overlay scrollbar fade out for non-composited scrollers. (Closed)
Patch Set: sigh....git cl format Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebThemeEngine.h
diff --git a/third_party/WebKit/public/platform/WebThemeEngine.h b/third_party/WebKit/public/platform/WebThemeEngine.h
index 8fe876d11d9b8f6647bde8d53955354c46014e4d..2387f462111bc2bf0ed1918521502caf8db4fd4b 100644
--- a/third_party/WebKit/public/platform/WebThemeEngine.h
+++ b/third_party/WebKit/public/platform/WebThemeEngine.h
@@ -163,10 +163,21 @@ class WebThemeEngine {
int thumbThickness;
int scrollbarMargin;
WebColor color;
+ double fadeOutDelaySeconds;
+ double fadeOutDurationSeconds;
};
- // Gets the overlay scrollbar style. Used for mobile theme.
- virtual void getOverlayScrollbarStyle(ScrollbarStyle*) {}
+ // Gets the overlay scrollbar style. Not used on Mac.
+ virtual void getOverlayScrollbarStyle(ScrollbarStyle* style) {
+ // Disable overlay scrollbar fade out (for non-composited scrollers) unless
+ // explicitly enabled by the implementing child class. NOTE: these values
+ // aren't used to control Mac fade out - that happens in ScrollAnimatorMac.
+ style->fadeOutDelaySeconds = 0.0;
+ style->fadeOutDurationSeconds = 0.0;
+ // The other fields in this struct are used only on Android to draw solid
+ // color scrollbars. On other platforms the scrollbars are painted in
+ // NativeTheme so these fields are unused in non-Android WebThemeEngines.
+ }
// Paint the given the given theme part.
virtual void paint(WebCanvas*,
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698