mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

When using the CoreAnimation compositor, RenderPassDrawQuads are copied to an
IOSurface. The opacity is already applied there, so there's no need for the
CoreAnimation Compositor to apply it again.

BUG=660600
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4a9cceac5f1883f48b564ad277d3d39cdd9f8615
Cr-Commit-Position: refs/heads/master@{#429060}

[erikchen, 2016-10-31 21:23:51]

Description was changed from

==========
mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

When using the CoreAnimation compositor, RenderPassDrawQuads are copied to an
IOSurface. The opacity is already applied there, so there's no need for the
CoreAnimation Compositor to apply it again.

BUG=660600
==========

to

==========
mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

When using the CoreAnimation compositor, RenderPassDrawQuads are copied to an
IOSurface. The opacity is already applied there, so there's no need for the
CoreAnimation Compositor to apply it again.

BUG=660600
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[erikchen, 2016-10-31 21:24:33]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-10-31 21:24:43]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-10-31 21:24:43]

ccameron: Please review.

[commit-bot: I haz the power, 2016-10-31 21:25:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-10-31 21:48:37]

lgtm

(test would be nice)

[commit-bot: I haz the power, 2016-10-31 22:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:32:27]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-10-31 23:16:56]

On 2016/10/31 21:48:37, ccameron wrote:
> lgtm
> 
> (test would be nice)

Added a test. Locally, the test has wrong behavior on CAnary, and right behavior
on ToT with this patch. Going to let the rebaselines go through automatically.

[erikchen, 2016-10-31 23:17:25]

erikchen@chromium.org changed reviewers:
+ kbr@chromium.org

[erikchen, 2016-10-31 23:17:25]

kbr: Please review content/test

[Ken Russell (switch to Gerrit), 2016-11-01 02:41:53]

Sorry about the confusion -- a different test file needs to be updated.

These two tests have been marked failing for a while in
src/content/test/gpu/gpu_tests/pixel_expectations.py . Is it expected that this
fix will make them start passing?

https://codereview.chromium.org/2467643002/diff/20001/content/test/gpu/page_s...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/2467643002/diff/20001/content/test/gpu/page_s...
content/test/gpu/page_sets/pixel_tests.py:206: self.AddStory(PixelTestsPage(
Sorry -- this file is only used by the trace_tests at this point, not the
pixel_tests -- please update src/content/test/gpu/gpu_tests/pixel_test_pages.py
instead. (I still need to convert the trace_tests to the new harness per
http://crbug.com/352807 .)

[erikchen, 2016-11-01 17:31:28]

> These two tests have been marked failing for a while in
> src/content/test/gpu/gpu_tests/pixel_expectations.py . Is it expected that
this
> fix will make them start passing?
Oops, I never marked them as passing even though they were.

[erikchen, 2016-11-01 17:31:35]

kbr: PTAL

https://codereview.chromium.org/2467643002/diff/20001/content/test/gpu/page_s...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/2467643002/diff/20001/content/test/gpu/page_s...
content/test/gpu/page_sets/pixel_tests.py:206: self.AddStory(PixelTestsPage(
On 2016/11/01 02:41:53, Ken Russell wrote:
> Sorry -- this file is only used by the trace_tests at this point, not the
> pixel_tests -- please update
src/content/test/gpu/gpu_tests/pixel_test_pages.py
> instead. (I still need to convert the trace_tests to the new harness per
> http://crbug.com/352807 .)

Done.

[Ken Russell (switch to Gerrit), 2016-11-01 17:35:54]

LGTM

Once the new reference images are generated, please remove the failure
expectations for these two tests (hopefully that'll be possible). :) Thanks.

[erikchen, 2016-11-01 17:36:46]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-11-01 17:36:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2467643002/#ps40001
(title: "Comments from kbr.")

[commit-bot: I haz the power, 2016-11-01 17:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:33:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 18:54:30]

Description was changed from

==========
mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

When using the CoreAnimation compositor, RenderPassDrawQuads are copied to an
IOSurface. The opacity is already applied there, so there's no need for the
CoreAnimation Compositor to apply it again.

BUG=660600
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
mac: Fix bug where opacity is applied twice on RenderPassDrawQuads.

When using the CoreAnimation compositor, RenderPassDrawQuads are copied to an
IOSurface. The opacity is already applied there, so there's no need for the
CoreAnimation Compositor to apply it again.

BUG=660600
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4a9cceac5f1883f48b564ad277d3d39cdd9f8615
Cr-Commit-Position: refs/heads/master@{#429060}
==========

[commit-bot: I haz the power, 2016-11-01 18:54:31]

Patchset 3 (id:??) landed as
https://crrev.com/4a9cceac5f1883f48b564ad277d3d39cdd9f8615
Cr-Commit-Position: refs/heads/master@{#429060}