Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3070)

Unified Diff: cc/trees/layer_tree_host_unittest_context.cc

Issue 246753008: cc: Unify use of DidSwapBuffers() and did_request_swap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Introduce HasSentDrawRequestThisFrame() Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest_context.cc
diff --git a/cc/trees/layer_tree_host_unittest_context.cc b/cc/trees/layer_tree_host_unittest_context.cc
index 84e324b93c21cf12f675a0ace6366dadd1051f9f..503cb4a946e1eb43eb9bb5f4fe302f529315498e 100644
--- a/cc/trees/layer_tree_host_unittest_context.cc
+++ b/cc/trees/layer_tree_host_unittest_context.cc
@@ -96,11 +96,11 @@ class LayerTreeHostContextTest : public LayerTreeTest {
return FakeOutputSurface::Create3d(context3d.Pass());
}
- virtual DrawSwapReadbackResult::DrawResult PrepareToDrawOnThread(
+ virtual DrawResult PrepareToDrawOnThread(
LayerTreeHostImpl* host_impl,
LayerTreeHostImpl::FrameData* frame,
- DrawSwapReadbackResult::DrawResult draw_result) OVERRIDE {
- EXPECT_EQ(DrawSwapReadbackResult::DRAW_SUCCESS, draw_result);
+ DrawResult draw_result) OVERRIDE {
+ EXPECT_EQ(DRAW_SUCCESS, draw_result);
if (!times_to_lose_during_draw_)
return draw_result;
@@ -854,10 +854,10 @@ class LayerTreeHostContextTestDontUseLostResources
}
}
- virtual DrawSwapReadbackResult::DrawResult PrepareToDrawOnThread(
+ virtual DrawResult PrepareToDrawOnThread(
LayerTreeHostImpl* host_impl,
LayerTreeHostImpl::FrameData* frame,
- DrawSwapReadbackResult::DrawResult draw_result) OVERRIDE {
+ DrawResult draw_result) OVERRIDE {
if (host_impl->active_tree()->source_frame_number() == 2) {
// Lose the context during draw on the second commit. This will cause
// a third commit to recover.
@@ -948,10 +948,10 @@ class LayerTreeHostContextTestCompositeAndReadbackBeforeOutputSurfaceInit
EXPECT_EQ(1, times_output_surface_created_);
}
- virtual DrawSwapReadbackResult::DrawResult PrepareToDrawOnThread(
+ virtual DrawResult PrepareToDrawOnThread(
LayerTreeHostImpl* host_impl,
LayerTreeHostImpl::FrameData* frame_data,
- DrawSwapReadbackResult::DrawResult draw_result) OVERRIDE {
+ DrawResult draw_result) OVERRIDE {
EXPECT_GE(host_impl->active_tree()->source_frame_number(), 0);
EXPECT_LE(host_impl->active_tree()->source_frame_number(), 1);
return draw_result;
@@ -1000,10 +1000,10 @@ class LayerTreeHostContextTestLoseOutputSurfaceDuringReadbackAndForcedDraw
virtual void BeginTest() OVERRIDE { PostSetNeedsCommitToMainThread(); }
- virtual DrawSwapReadbackResult::DrawResult PrepareToDrawOnThread(
+ virtual DrawResult PrepareToDrawOnThread(
LayerTreeHostImpl* host_impl,
LayerTreeHostImpl::FrameData* frame_data,
- DrawSwapReadbackResult::DrawResult draw_result) OVERRIDE {
+ DrawResult draw_result) OVERRIDE {
int sfn = host_impl->active_tree()->source_frame_number();
EXPECT_TRUE(sfn == kFirstOutputSurfaceInitSourceFrameNumber ||
sfn == kSecondOutputSurfaceInitSourceFrameNumber ||
@@ -1020,7 +1020,7 @@ class LayerTreeHostContextTestLoseOutputSurfaceDuringReadbackAndForcedDraw
LoseContext();
}
- return DrawSwapReadbackResult::DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
+ return DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
}
virtual void InitializedRendererOnThread(LayerTreeHostImpl* host_impl,
@@ -1079,10 +1079,10 @@ class LayerTreeHostContextTestReadbackWithForcedDrawAndOutputSurfaceInit
virtual void BeginTest() OVERRIDE { PostSetNeedsCommitToMainThread(); }
- virtual DrawSwapReadbackResult::DrawResult PrepareToDrawOnThread(
+ virtual DrawResult PrepareToDrawOnThread(
LayerTreeHostImpl* host_impl,
LayerTreeHostImpl::FrameData* frame_data,
- DrawSwapReadbackResult::DrawResult draw_result) OVERRIDE {
+ DrawResult draw_result) OVERRIDE {
int sfn = host_impl->active_tree()->source_frame_number();
EXPECT_TRUE(sfn == kFirstOutputSurfaceInitSourceFrameNumber ||
sfn == kSecondOutputSurfaceInitSourceFrameNumber ||
@@ -1098,7 +1098,7 @@ class LayerTreeHostContextTestReadbackWithForcedDrawAndOutputSurfaceInit
}
// Returning false will result in a forced draw.
- return DrawSwapReadbackResult::DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
+ return DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
}
virtual void DidInitializeOutputSurface() OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698