Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2874)

Unified Diff: cc/scheduler/scheduler_state_machine.h

Issue 246753008: cc: Unify use of DidSwapBuffers() and did_request_swap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_state_machine.h
diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h
index ff032b669670779f5150d83f4d0b9d0d5f0ac03f..25d3c050fa6441ddb80c4158396e085c153e63f9 100644
--- a/cc/scheduler/scheduler_state_machine.h
+++ b/cc/scheduler/scheduler_state_machine.h
@@ -12,7 +12,7 @@
#include "base/time/time.h"
#include "cc/base/cc_export.h"
#include "cc/output/begin_frame_args.h"
-#include "cc/scheduler/draw_swap_readback_result.h"
+#include "cc/scheduler/draw_result.h"
#include "cc/scheduler/scheduler_settings.h"
namespace base {
@@ -193,7 +193,7 @@ class CC_EXPORT SchedulerStateMachine {
bool smoothness_takes_priority() const { return smoothness_takes_priority_; }
// Indicates whether ACTION_DRAW_AND_SWAP_IF_POSSIBLE drew to the screen.
- void DidDrawIfPossibleCompleted(DrawSwapReadbackResult::DrawResult result);
+ void DidDrawIfPossibleCompleted(DrawResult result);
// Indicates that a new commit flow needs to be performed, either to pull
// updates from the main thread to the impl, or to push deltas from the impl
@@ -270,8 +270,10 @@ class CC_EXPORT SchedulerStateMachine {
void AdvanceCurrentFrameNumber();
bool HasSentBeginMainFrameThisFrame() const;
+ bool HasRequestedDrawThisFrame() const;
bool HasUpdatedVisibleTilesThisFrame() const;
bool HasSwappedThisFrame() const;
+ bool HasRequestedSwapThisFrame() const;
brianderson 2014/05/08 17:40:19 nit: Here and elsewhere, can you reorder these so
simonhong 2014/05/09 00:18:40 Done.
void UpdateStateOnCommit(bool commit_was_aborted);
void UpdateStateOnActivation();
@@ -292,7 +294,9 @@ class CC_EXPORT SchedulerStateMachine {
int current_frame_number_;
int last_frame_number_animate_performed_;
int last_frame_number_swap_performed_;
+ int last_frame_number_swap_request_sent_;
brianderson 2014/05/08 17:40:19 last_frame_number_swap_requested_
simonhong 2014/05/09 00:18:40 Done.
int last_frame_number_begin_main_frame_sent_;
+ int last_frame_number_draw_request_sent_;
brianderson 2014/05/08 17:40:19 last_frame_number_draw_requested_;
simonhong 2014/05/09 00:18:40 Done.
int last_frame_number_update_visible_tiles_was_called_;
// manage_tiles_funnel_ is "filled" each time ManageTiles is called

Powered by Google App Engine
This is Rietveld 408576698