Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 2467513002: [builtins]: Uniformly push argument count in TF-generated builtins (Closed)
Patch Set: Cleanup arm64 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 #include "src/compilation-info.h" 6 #include "src/compilation-info.h"
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/osr.h" 10 #include "src/compiler/osr.h"
(...skipping 2226 matching lines...) Expand 10 before | Expand all | Expand 10 after
2237 if (descriptor->IsCFunctionCall()) { 2237 if (descriptor->IsCFunctionCall()) {
2238 __ Push(ra, fp); 2238 __ Push(ra, fp);
2239 __ mov(fp, sp); 2239 __ mov(fp, sp);
2240 } else if (descriptor->IsJSFunctionCall()) { 2240 } else if (descriptor->IsJSFunctionCall()) {
2241 __ Prologue(this->info()->GeneratePreagedPrologue()); 2241 __ Prologue(this->info()->GeneratePreagedPrologue());
2242 } else { 2242 } else {
2243 __ StubPrologue(info()->GetOutputStackFrameType()); 2243 __ StubPrologue(info()->GetOutputStackFrameType());
2244 } 2244 }
2245 } 2245 }
2246 2246
2247 int shrink_slots = frame()->GetSpillSlotCount(); 2247 int shrink_slots =
2248 frame()->GetTotalFrameSlotCount() - descriptor->CalculateFixedFrameSize();
2248 2249
2249 if (info()->is_osr()) { 2250 if (info()->is_osr()) {
2250 // TurboFan OSR-compiled functions cannot be entered directly. 2251 // TurboFan OSR-compiled functions cannot be entered directly.
2251 __ Abort(kShouldNotDirectlyEnterOsrFunction); 2252 __ Abort(kShouldNotDirectlyEnterOsrFunction);
2252 2253
2253 // Unoptimized code jumps directly to this entrypoint while the unoptimized 2254 // Unoptimized code jumps directly to this entrypoint while the unoptimized
2254 // frame is still on the stack. Optimized code uses OSR values directly from 2255 // frame is still on the stack. Optimized code uses OSR values directly from
2255 // the unoptimized frame. Thus, all that needs to be done is to allocate the 2256 // the unoptimized frame. Thus, all that needs to be done is to allocate the
2256 // remaining stack slots. 2257 // remaining stack slots.
2257 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --"); 2258 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2539 padding_size -= v8::internal::Assembler::kInstrSize; 2540 padding_size -= v8::internal::Assembler::kInstrSize;
2540 } 2541 }
2541 } 2542 }
2542 } 2543 }
2543 2544
2544 #undef __ 2545 #undef __
2545 2546
2546 } // namespace compiler 2547 } // namespace compiler
2547 } // namespace internal 2548 } // namespace internal
2548 } // namespace v8 2549 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698