Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2467503003: Remove GetWidget() overrides (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove GetWidget() overrides This Cl removes the various CFWL_*::GetWidget overrides and adds anonymous To* methods as needed. Committed: https://pdfium.googlesource.com/pdfium/+/42cb64572198bf8a72de9b18eae9f9dd9a07beb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -248 lines) Patch
M xfa/fwl/core/cfwl_barcode.h View 1 chunk +14 lines, -59 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.cpp View 2 chunks +64 lines, -7 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 4 chunks +49 lines, -40 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 4 chunks +31 lines, -30 lines 0 comments Download
M xfa/fwl/core/cfwl_edit.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_edit.cpp View 5 chunks +50 lines, -47 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-10-31 18:20:43 UTC) #2
npm
lgtm but why not use private methods instead of namespace? To save us from calling ...
4 years, 1 month ago (2016-10-31 19:34:36 UTC) #7
dsinclair
On 2016/10/31 19:34:36, npm wrote: > lgtm but why not use private methods instead of ...
4 years, 1 month ago (2016-10-31 19:49:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467503003/1
4 years, 1 month ago (2016-10-31 19:49:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 19:50:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/42cb64572198bf8a72de9b18eae9f9dd9a07...

Powered by Google App Engine
This is Rietveld 408576698