Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467493003: Compute NativeBehavior for native methods and fields. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute NativeBehavior for native methods and fields. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/6cc90ed0f891504386e5797eed56b2022ff167ee

Patch Set 1 #

Patch Set 2 : Remove commented code. #

Total comments: 6

Patch Set 3 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -13 lines) Patch
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +4 lines, -1 line 0 comments Download
A pkg/compiler/lib/src/kernel/constant_visitor.dart View 1 chunk +155 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 4 chunks +20 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 9 chunks +139 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Johnni Winther
4 years, 1 month ago (2016-10-31 14:25:33 UTC) #2
Johnni Winther
ping
4 years, 1 month ago (2016-11-01 11:11:24 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2467493003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2467493003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode345 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:345: /// Return `true` if [node] is the `dart:_foregin_helper` ...
4 years, 1 month ago (2016-11-01 17:26:27 UTC) #4
Johnni Winther
https://codereview.chromium.org/2467493003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2467493003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode345 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:345: /// Return `true` if [node] is the `dart:_foregin_helper` library. ...
4 years, 1 month ago (2016-11-02 15:16:27 UTC) #6
Johnni Winther
4 years, 1 month ago (2016-11-02 15:21:47 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as
6cc90ed0f891504386e5797eed56b2022ff167ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698