Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2467483002: Add spread call micro-benchmarks. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add spread call micro-benchmarks. Taken from http://kpdecker.github.io/six-speed/ Committed: https://crrev.com/7159662b3177fc4d93f97e34ac21a614db5109b5 Cr-Commit-Position: refs/heads/master@{#40837}

Patch Set 1 #

Patch Set 2 : rename #

Total comments: 3

Patch Set 3 : moved a bit around, now use our own benchmark suite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -4 lines) Patch
A test/js-perf-test/SixSpeed.json View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/LICENSE.sixspeed View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A + test/js-perf-test/SixSpeed/spread/run.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
A test/js-perf-test/SixSpeed/spread/spread.js View 1 2 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Yang
Please take a look.
4 years, 1 month ago (2016-10-31 12:45:29 UTC) #2
Yang
Michael, could you take a look while Michael is on parental leave? :)
4 years, 1 month ago (2016-11-07 07:26:56 UTC) #4
Michael Achenbach
Is it right to add it to our existing js tests? Since it is a ...
4 years, 1 month ago (2016-11-07 07:34:37 UTC) #5
Yang
https://codereview.chromium.org/2467483002/diff/20001/test/js-perf-test/JSTests.json File test/js-perf-test/JSTests.json (right): https://codereview.chromium.org/2467483002/diff/20001/test/js-perf-test/JSTests.json#newcode239 test/js-perf-test/JSTests.json:239: "name": "SixSpeed", On 2016/11/07 07:34:37, machenbach (slow) wrote: > ...
4 years, 1 month ago (2016-11-07 10:32:19 UTC) #6
Yang
As discussed, I created a new JSON file for this, and removed dependencies on files ...
4 years, 1 month ago (2016-11-07 10:33:07 UTC) #7
Yang
On 2016/11/07 10:33:07, Yang wrote: > As discussed, I created a new JSON file for ...
4 years, 1 month ago (2016-11-08 13:38:35 UTC) #8
Michael Achenbach
LGTM
4 years, 1 month ago (2016-11-08 13:46:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467483002/40001
4 years, 1 month ago (2016-11-08 13:51:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 14:17:04 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:18 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7159662b3177fc4d93f97e34ac21a614db5109b5
Cr-Commit-Position: refs/heads/master@{#40837}

Powered by Google App Engine
This is Rietveld 408576698