Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2467473002: [turbofan] Use an IntPtrConstant in WordEqual comparisons. (Closed)

Created:
4 years, 1 month ago by georgia.kouveli
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use an IntPtrConstant in WordEqual comparisons. ZeroConstant is a NumberConstant, so does not get matched in IntMatchers, which results in missing some opportunities in instruction selection. Use IntPtrConstant instead, which generates an Int32Constant or an Int64Constant depending on the word size. BUG= Committed: https://crrev.com/70dfb5a0d648ade2936b3203b53cde5a9abf660a Cr-Commit-Position: refs/heads/master@{#40669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
4 years, 1 month ago (2016-10-31 11:48:36 UTC) #2
epertoso
lgtm, thank you!
4 years, 1 month ago (2016-10-31 11:54:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467473002/1
4 years, 1 month ago (2016-10-31 11:55:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 12:23:11 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70dfb5a0d648ade2936b3203b53cde5a9abf660a
Cr-Commit-Position: refs/heads/master@{#40669}

Powered by Google App Engine
This is Rietveld 408576698