Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2467463002: Optionally create internal fields on global proxy objects (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create internal fields on global proxy objects BUG=v8:5588 R=verwaest@chromium.org Committed: https://crrev.com/26547761efbcb6ed0d07f894afe3cbf2b5dd0068 Cr-Commit-Position: refs/heads/master@{#40670}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M include/v8.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/api-natives.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M src/factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jochen (gone - plz use gerrit)
4 years, 1 month ago (2016-10-31 11:45:59 UTC) #1
jochen (gone - plz use gerrit)
tests pass with and without the flag enabled, so I guess I could just flip ...
4 years, 1 month ago (2016-10-31 11:47:04 UTC) #4
jochen (gone - plz use gerrit)
updated after offline feedback
4 years, 1 month ago (2016-10-31 13:39:22 UTC) #8
Toon Verwaest
lgtm
4 years, 1 month ago (2016-10-31 13:42:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467463002/20001
4 years, 1 month ago (2016-10-31 13:46:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 14:15:43 UTC) #12
Michael Achenbach
Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11029 Online revert doesn't work, because it claims file too large. Please ...
4 years, 1 month ago (2016-11-01 19:48:25 UTC) #14
Michael Achenbach
Created revert manually: https://codereview.chromium.org/2467073002/
4 years, 1 month ago (2016-11-01 20:06:52 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26547761efbcb6ed0d07f894afe3cbf2b5dd0068
Cr-Commit-Position: refs/heads/master@{#40670}

Powered by Google App Engine
This is Rietveld 408576698