Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2467413002: Fix MediaGalleriesPlatformAppBrowserTest tests with PlzNavigate. (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews, Lei Zhang, chromium-apps-reviews_chromium.org, tommycli, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MediaGalleriesPlatformAppBrowserTest tests with PlzNavigate. r217066 added a dummy app window to keep the app alive during the test. This gives errors in the chrome apps JS because the file doesn't actually exist, so the chrome apps JS objects aren't injected. This works without PlzNavigate because the JS objects are injected based on the provisional load URL, which is valid (this is before the renderer finds out the file doesn't exist). With PlzNavigate, the frame is instead navigated to an error page URL, which we don't inject chrome apps bindings in. Fix this by increasing the apps timeout value in C++ in the test harness. This fixes MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead MediaGalleriesPlatformAppBrowserTest.Scan MediaGalleriesPlatformAppBrowserTest.ToURL with PlzNavigate. BUG=504347 Committed: https://crrev.com/9f396cd685f05bf2d4d9f86c7e3d0e0ed85790f8 Cr-Commit-Position: refs/heads/master@{#429477}

Patch Set 1 : a #

Messages

Total messages: 16 (11 generated)
jam
4 years, 1 month ago (2016-11-02 20:28:51 UTC) #7
tommycli
if indeed we can get rid of the dummy window, then great! lgtm
4 years, 1 month ago (2016-11-03 00:22:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467413002/20001
4 years, 1 month ago (2016-11-03 00:24:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-03 00:34:26 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:36:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f396cd685f05bf2d4d9f86c7e3d0e0ed85790f8
Cr-Commit-Position: refs/heads/master@{#429477}

Powered by Google App Engine
This is Rietveld 408576698