tools/dev/v8gen.py - Issue 2467363002: v8gen.py: change file open mode from 'aw' to just 'a'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dev/v8gen.py

Issue 2467363002: v8gen.py: change file open mode from 'aw' to just 'a' (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dev/v8gen.py

diff --git a/tools/dev/v8gen.py b/tools/dev/v8gen.py

index f0fb74b7094608373c94beb88b0f48f0c9d5c995..b8a34e2af2b68910663b940bca1412f1a5d837c0 100755

--- a/tools/dev/v8gen.py

+++ b/tools/dev/v8gen.py

@@ -269,7 +269,7 @@ class GenerateGnArgs(object):

# Artificially increment modification time as our modifications happen too

# fast. This makes sure that gn is properly rebuilding the ninja files.

mtime = os.path.getmtime(gn_args_path) + 1

- with open(gn_args_path, 'aw'):

+ with open(gn_args_path, 'a'):

os.utime(gn_args_path, (mtime, mtime))

return True

« no previous file with comments | « no previous file | no next file » | no next file with comments »