Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2467363002: v8gen.py: change file open mode from 'aw' to just 'a' (Closed)

Created:
4 years, 1 month ago by Derek Schuff
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

v8gen.py: change file open mode from 'aw' to just 'a' 'a' and 'w' are mutually exclusive and just 'a' is what we actually want. Linux doesn't care (it just takes the first one) but Windows throws a ValueError. R=machenbach@chromium.org BUG=None Committed: https://crrev.com/4d2659a706bf02cbea7387e2a8e7b289f016d81b Cr-Commit-Position: refs/heads/master@{#40711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/dev/v8gen.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Derek Schuff
4 years, 1 month ago (2016-11-02 18:13:44 UTC) #3
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-02 20:25:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467363002/1
4 years, 1 month ago (2016-11-02 22:01:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 22:03:46 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d2659a706bf02cbea7387e2a8e7b289f016d81b
Cr-Commit-Position: refs/heads/master@{#40711}

Powered by Google App Engine
This is Rietveld 408576698