Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2467343002: Revert of aw: Enable async ondraw by default (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of aw: Enable async ondraw by default (patchset #1 id:1 of https://codereview.chromium.org/2457063002/ ) Reason for revert: Probable cause for memory regression (or leak?) BUG=661504 Original issue's description: > aw: Enable async ondraw by default > > First attempt at enabling. Hopefully it sticks. > > BUG=636164 > > Committed: https://crrev.com/28281dff0b3e8fd9702bfffa8e90e8212e53f16f > Cr-Commit-Position: refs/heads/master@{#428460} TBR=sgurun@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636164 Committed: https://crrev.com/6630072d85dabb1306ed6e4b850a0f9b133f848d Cr-Commit-Position: refs/heads/master@{#429352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of aw: Enable async ondraw by default
4 years, 1 month ago (2016-11-02 17:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467343002/1
4 years, 1 month ago (2016-11-02 17:57:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 18:54:16 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:55:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6630072d85dabb1306ed6e4b850a0f9b133f848d
Cr-Commit-Position: refs/heads/master@{#429352}

Powered by Google App Engine
This is Rietveld 408576698