Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2467333003:
[Offline Pages] Coordinator checks for net connection before starting next req (Closed)
|
Created:
4 years, 1 month ago by dougarnett Modified:
4 years, 1 month ago Reviewers:
Pete Williamson CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Offline Pages] Coordinator checks for net connection before starting next req
As part of improving the servicing of background load requests, we should
avoid scheduling the next request if we have lost the network connection (to
save resources and attempt count). When the network comes back then we want
scheduler to start us again.
BUG=655341
Committed: https://crrev.com/12aa9df385dcd9e1b85ead71827358bc32648873
Cr-Commit-Position: refs/heads/master@{#430027}
Patch Set 1 #Patch Set 2 : Moved is_starting to all TryNextRequest cases and try to fix test #Patch Set 3 : Got tests running #
Messages
Total messages: 27 (20 generated)
The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dougarnett@chromium.org changed reviewers: + petewil@chromium.org
Also fixed couple additional items: - Moved setting is_starting_ inside TryNextRequest to cover multiple entry paths instead of just one. - Fixed PoorConnection test since logic changed recently to proceed with poor connection. And changed default network state in SetUp with new helper to set both connection sources.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by dougarnett@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dougarnett@chromium.org
The CQ bit was checked by dougarnett@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Offline Pages] Coordinator checks for net connection before starting next req As part of improving the servicing of background load requests, we should avoid scheduling the next request if we have lost the network connection (to save resources and attempt count). When the network comes back then we want scheduler to start us again. BUG=655341 ========== to ========== [Offline Pages] Coordinator checks for net connection before starting next req As part of improving the servicing of background load requests, we should avoid scheduling the next request if we have lost the network connection (to save resources and attempt count). When the network comes back then we want scheduler to start us again. BUG=655341 Committed: https://crrev.com/12aa9df385dcd9e1b85ead71827358bc32648873 Cr-Commit-Position: refs/heads/master@{#430027} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/12aa9df385dcd9e1b85ead71827358bc32648873 Cr-Commit-Position: refs/heads/master@{#430027} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
