dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart - Issue 246733004: Don't use fatal errors in message_kind_test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

Issue 246733004: Don't use fatal errors in message_kind_test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | dart/tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

index b9d9fd9bb4489c24bab317f7a75f7894ee8662b6..feedce14cdb9141feac2039bb2f9d91702ba9f9c 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

@@ -199,7 +199,7 @@ class SignatureResolver extends MappingVisitor<ParameterElementX> {

}

Node defaultValue = node.arguments.head;

if (!defaultValuesAllowed) {

- error(defaultValue, defaultValuesError);

+ compiler.reportError(defaultValue, defaultValuesError);

}

// Visit the value. The compile time constant handler will

// make sure it's a compile time constant.