Issue 246733003: Context-allocate all parameters in generators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246733003: Context-allocate all parameters in generators (Closed)

Created:
6 years, 8 months ago by wingo

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Context-allocate all parameters in generators Generator function scopes have forced context allocation. Ensure that all variables in such scopes get context allocation -- even unused variables. This fixes an assertion when reifying generator scopes in the debugger. R=yangguo@chromium.org LOG=Y BUG=v8:3280 Committed: https://code.google.com/p/v8/source/detail?r=20883

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	src/scopes.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-3280.js	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 8 months ago (2014-04-22 15:01:08 UTC) #4

Message was sent while issue was closed.

On 2014/04/22 11:34:32, wingo wrote:
> Committed patchset #1 manually as r20883.

now that I looked, the test should be put into test/mjsunit/harmony/regress/

Expand Messages | Collapse Messages