Update ash_layout_constants after changing meaning of ui::MDC::GetMode()

Update ash_layout_constants after changing meaning of ui::MDC::GetMode()

BUG=661234
Committed: https://crrev.com/2b2e3f9c387dd83d1df6ccbe4f797176e4440d88
Cr-Commit-Position: refs/heads/master@{#429692}

[Evan Stade, 2016-11-02 22:24:36]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[tdanderson, 2016-11-03 17:16:13]

LGTM, though I am not an owner of this file.

[Evan Stade, 2016-11-03 17:55:22]

estade@chromium.org changed reviewers:
+ derat@chromium.org

[Evan Stade, 2016-11-03 17:55:22]

+derat

[Daniel Erat, 2016-11-03 18:37:20]

lgtm

https://codereview.chromium.org/2467313003/diff/1/ash/common/ash_layout_const...
File ash/common/ash_layout_constants.cc (right):

https://codereview.chromium.org/2467313003/diff/1/ash/common/ash_layout_const...
ash/common/ash_layout_constants.cc:18: const int mode =
ui::MaterialDesignController::GetMode();
maybe DCHECK_LT(mode, arraysize(kBrowserMaximizedCaptionButtonHeight)) or
something similar?

[Evan Stade, 2016-11-03 19:29:00]

https://codereview.chromium.org/2467313003/diff/1/ash/common/ash_layout_const...
File ash/common/ash_layout_constants.cc (right):

https://codereview.chromium.org/2467313003/diff/1/ash/common/ash_layout_const...
ash/common/ash_layout_constants.cc:18: const int mode =
ui::MaterialDesignController::GetMode();
On 2016/11/03 18:37:20, Daniel Erat wrote:
> maybe DCHECK_LT(mode, arraysize(kBrowserMaximizedCaptionButtonHeight)) or
> something similar?

it wouldn't have helped in this case, as the enum values went from 0,1,2 to 0,1
(i.e. we didn't have an out of range issue, we just had an off by one error)

[Evan Stade, 2016-11-03 19:29:04]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-11-03 19:29:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:55:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 20:57:45]

Description was changed from

==========
Update ash_layout_constants after changing meaning of ui::MDC::GetMode()

BUG=661234
==========

to

==========
Update ash_layout_constants after changing meaning of ui::MDC::GetMode()

BUG=661234

Committed: https://crrev.com/2b2e3f9c387dd83d1df6ccbe4f797176e4440d88
Cr-Commit-Position: refs/heads/master@{#429692}
==========

[commit-bot: I haz the power, 2016-11-03 20:57:46]

Patchset 1 (id:??) landed as
https://crrev.com/2b2e3f9c387dd83d1df6ccbe4f797176e4440d88
Cr-Commit-Position: refs/heads/master@{#429692}