Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 24673006: dbus: Stop accessing ObjectProxy::name_owner_changed_callback_ on the D-Bus thread (Closed)

Created:
7 years, 2 months ago by hashimoto
Modified:
7 years, 2 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

dbus: Stop accessing ObjectProxy::name_owner_changed_callback_ on the D-Bus thread Accessing the callback on the D-Bus thread while changing its value may result in a race condition. Change the type of SetNameOwnerChangedCallback's argument from Signal to strings to stop worrying about on which thread the Signal gets released. BUG=298747 TEST=dbus_unittests R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225675

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M chromeos/dbus/cras_audio_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dbus/object_proxy.h View 4 chunks +11 lines, -2 lines 0 comments Download
M dbus/object_proxy.cc View 4 chunks +18 lines, -19 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
7 years, 2 months ago (2013-09-26 10:37:39 UTC) #1
satorux1
LGTM. looks a lot simpler!
7 years, 2 months ago (2013-09-26 10:41:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/24673006/3001
7 years, 2 months ago (2013-09-26 11:09:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=81676
7 years, 2 months ago (2013-09-26 15:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/24673006/3001
7 years, 2 months ago (2013-09-27 04:00:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159360
7 years, 2 months ago (2013-09-27 06:13:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/24673006/3001
7 years, 2 months ago (2013-09-27 06:18:42 UTC) #7
hashimoto
7 years, 2 months ago (2013-09-27 07:12:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r225675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698