Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467283003: Revert "Make EfficientLength extend Iterable." (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Chinmay
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make EfficientLength extend Iterable." This reverts commit b08fb1373f88121bb4056adce9b71849a5bede2a. TBR=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/6cf5c3baa39074912f21542077416fa5b7a9f9b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M runtime/lib/array_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/collection_patch.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/collection_patch.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/linked_hash_map.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/maps.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 11 chunks +12 lines, -12 lines 0 comments Download
M tests/corelib/growable_list_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
D tests/language/efficient_length_warning_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
rmacnak
This change appears to have broken the analyzer as used by Flutter (https://travis-ci.org/flutter/flutter/builds/172706676). The new ...
4 years, 1 month ago (2016-11-02 20:19:01 UTC) #2
rmacnak
4 years, 1 month ago (2016-11-02 20:20:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6cf5c3baa39074912f21542077416fa5b7a9f9b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698