Collect total counters in case of GDI failure.

base/debug/gdi_debug_util_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "base/debug/gdi_debug_util_win.h"
 
 #include <cmath>
 
 #include <psapi.h>
 #include <stddef.h>
 #include <TlHelp32.h>
 
 #include "base/debug/alias.h"
 #include "base/logging.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/win_util.h"
 
 namespace {
 
 void CollectChildGDIUsageAndDie(DWORD parent_pid) {
   HANDLE snapshot = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
   CHECK_NE(INVALID_HANDLE_VALUE, snapshot);
 
+  int total_process_count = 0;
+  base::debug::Alias(&total_process_count);
+  int total_peak_gdi_count = 0;
+  base::debug::Alias(&total_peak_gdi_count);
+  int total_gdi_count = 0;
+  base::debug::Alias(&total_gdi_count);
+  int total_user_count = 0;
+  base::debug::Alias(&total_user_count);
+
   int child_count = 0;
   base::debug::Alias(&child_count);
   int peak_gdi_count = 0;
   base::debug::Alias(&peak_gdi_count);
   int sum_gdi_count = 0;
   base::debug::Alias(&sum_gdi_count);
   int sum_user_count = 0;
   base::debug::Alias(&sum_user_count);
 
   PROCESSENTRY32 proc_entry = {0};
   proc_entry.dwSize = sizeof(PROCESSENTRY32);
   CHECK(Process32First(snapshot, &proc_entry));
 
   do {
-    if (parent_pid != proc_entry.th32ParentProcessID)
-      continue;
-    // Got a child process. Compute GDI usage.
     base::win::ScopedHandle process(
         OpenProcess(PROCESS_QUERY_INFORMATION,
                     FALSE,
                     proc_entry.th32ProcessID));
     if (!process.IsValid())
       continue;
 
     int num_gdi_handles = GetGuiResources(process.Get(), GR_GDIOBJECTS);
     int num_user_handles = GetGuiResources(process.Get(), GR_USEROBJECTS);
 
-    // Compute sum and peak counts.
+    // Compute sum and peak counts for all processes.
+    ++total_process_count;
+    total_user_count += num_user_handles;
+    total_gdi_count += num_gdi_handles;
+    if (total_peak_gdi_count < num_gdi_handles)

[Lei Zhang, 2016/11/03 18:53:11]

total_peak_gdi_count = std::max(total_peak_gdi_count, num_gdi_handles);

Also line 70, if you don't mind.

+      total_peak_gdi_count = num_gdi_handles;
+
+    if (parent_pid != proc_entry.th32ParentProcessID)
+      continue;
+
+    // Compute sum and peak counts for child processes.
     ++child_count;
     sum_user_count += num_user_handles;
     sum_gdi_count += num_gdi_handles;
     if (peak_gdi_count < num_gdi_handles)
       peak_gdi_count = num_gdi_handles;
 
   } while (Process32Next(snapshot, &proc_entry));
 
   CloseHandle(snapshot);
   CHECK(false);
@@ skipping 56 matching lines @@
         0, &small_data, shared_section, 0);
     CHECK(small_bitmap != nullptr);
     DeleteObject(small_bitmap);
   }
   // Maybe the child processes are the ones leaking GDI or USER resouces.
   CollectChildGDIUsageAndDie(GetCurrentProcessId());
 }
 
 }  // namespace debug
 }  // namespace base