Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2467263002: INPUT/TEXTAREA elements: Dispatch 'change' event even if a user-edit value is overwritten by JS (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT/TEXTAREA elements: Dispatch 'change' event even if a user-edit value is overwritten by JavaScript Old behavior: 'change' event was dispatched on blur if the last edit was done by a user, and it changed the value. New behavior: 'change' event is dispatched on blur if a user has edited the value after the last 'change' event, and the value is changed. Updating value by JavaScript doesn't matter. We had the old behavior because |value| IDL setter updated textAsOfLastFormControlChangeEvent. With this CL, |value| IDL setter updates textAsOfLastFormControlChangeEvent only if the element is not focused. New behavior matches to Firefox and Presto. BUG=92492 Committed: https://crrev.com/e91b6459cf18e90f2766a68a2487701610213be4 Cr-Commit-Position: refs/heads/master@{#430531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/onchange-js.html View 1 chunk +65 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onchange-js-expected.txt View 1 chunk +32 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +16 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
tkent
Keishi, would you review this please?
4 years, 1 month ago (2016-11-08 03:29:10 UTC) #14
keishi
LGTM
4 years, 1 month ago (2016-11-08 05:07:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467263002/40001
4 years, 1 month ago (2016-11-08 05:55:05 UTC) #19
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-11-08 06:04:11 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 06:06:03 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e91b6459cf18e90f2766a68a2487701610213be4
Cr-Commit-Position: refs/heads/master@{#430531}

Powered by Google App Engine
This is Rietveld 408576698