Remove "legacy" experimental stream support

Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951

BUG=659965
Committed: https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313
Cr-Commit-Position: refs/heads/master@{#430513}

[yhirano, 2016-11-02 08:17:10]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 08:17:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-02 08:31:15]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 08:31:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-02 08:43:21]

Description was changed from

==========
Remove "legacy" stream support from XHR

BUG=659965
==========

to

==========
Remove "legacy" experimental stream support

BUG=659965
==========

[yhirano, 2016-11-02 08:45:45]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 08:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 10:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 10:22:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-11-02 11:25:50]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 11:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-02 11:31:24]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 11:31:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 11:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 11:44:45]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[yhirano, 2016-11-02 11:48:44]

Patchset #5 (id:80001) has been deleted

[yhirano, 2016-11-03 13:10:35]

Description was changed from

==========
Remove "legacy" experimental stream support

BUG=659965
==========

to

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.


BUG=659965
==========

[yhirano, 2016-11-03 13:10:35]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org, wolenetz@chromium.org

[yhirano, 2016-11-03 13:12:08]

+tyoshino@ for core/xmlhttprequest and core/stream (and tests).
+wolenetz@ for modules/mediasource (and tests).

[wolenetz, 2016-11-03 18:02:40]

There's some pieces (appendBuffer tests) which need to be kept, and some pieces
(appendStream impl in SourceBuffer.h and SourceBuffer.cpp) which need removal.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:828: crbug.com/524160 [ Debug ]
http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
[ Timeout ]
appendbuffer != appendstream

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:833: crbug.com/630342
virtual/mse-1mb-buffers/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
[ Skip ]
ditto

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:835: crbug.com/630342
http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html
[ Skip ]
ditto

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html
(left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html:1:
<!DOCTYPE html>
do not remove this

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
(left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html:1:
<!DOCTYPE html>
do not remove this

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl (left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl:73:
[RaisesException, RuntimeEnabled=ExperimentalStream] void appendStream(Stream
stream, optional unsigned long long maxSize);
This CL still leaves SourceBuffer.cpp and SourceBuffer.h appendStream
functionality (though removes the web-app visible IDL.) I assume the CL should
contain a full removal of appendStream functionality, or were you intending
something different?

[yhirano, 2016-11-04 02:13:28]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 02:14:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:12:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yhirano, 2016-11-04 07:35:21]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 07:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-04 07:42:27]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 07:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:09:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-11-04 12:44:22]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 12:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 14:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 14:38:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-11-04 16:52:14]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:36:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:36:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-11-07 02:11:59]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 02:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 03:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 03:59:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-11-07 04:38:12]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 04:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 06:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 06:14:18]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-07 06:36:52]

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:828: crbug.com/524160 [ Debug ]
http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
[ Timeout ]
On 2016/11/03 18:02:40, wolenetz wrote:
> appendbuffer != appendstream

Done.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:833: crbug.com/630342
virtual/mse-1mb-buffers/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
[ Skip ]
On 2016/11/03 18:02:40, wolenetz wrote:
> ditto

Done.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:835: crbug.com/630342
http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html
[ Skip ]
On 2016/11/03 18:02:40, wolenetz wrote:
> ditto

Done.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html
(left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html:1:
<!DOCTYPE html>
On 2016/11/03 18:02:40, wolenetz wrote:
> do not remove this

Done.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
(left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html:1:
<!DOCTYPE html>
On 2016/11/03 18:02:40, wolenetz wrote:
> do not remove this

Done.

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl (left):

https://codereview.chromium.org/2467233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl:73:
[RaisesException, RuntimeEnabled=ExperimentalStream] void appendStream(Stream
stream, optional unsigned long long maxSize);
On 2016/11/03 18:02:40, wolenetz wrote:
> This CL still leaves SourceBuffer.cpp and SourceBuffer.h appendStream
> functionality (though removes the web-app visible IDL.) I assume the CL should
> contain a full removal of appendStream functionality, or were you intending
> something different?

Done.

[tyoshino (SeeGerritForStatus), 2016-11-07 10:27:14]

lgtm

[wolenetz, 2016-11-07 19:42:00]

Thanks for doing this clean-up!
LGTM %:
1. remove unused enum (see below)
2. mention in CL description that appendStream was removed from MSE v1 (possibly
also reference
https://github.com/w3c/media-source/issues/14#issuecomment-238363951)

Note, you'll also need .../Source/core and .../Source/platform OWNER l*tm.

https://codereview.chromium.org/2467233002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasource/SourceBuffer.h (right):

https://codereview.chromium.org/2467233002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasource/SourceBuffer.h:120: enum
AppendStreamDoneAction {
Please also remove this enum. It was only used in the now-removed
appendStreamDone(....) caller and method.

[yhirano, 2016-11-08 01:36:56]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:37:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-08 01:39:54]

Description was changed from

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.


BUG=659965
==========

to

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951



BUG=659965
==========

[yhirano, 2016-11-08 03:24:41]

yhirano@chromium.org changed reviewers:
+ tkent@chromium.org

[yhirano, 2016-11-08 03:24:41]

+tkent@ for core/core_idl_files.gni and platform/RuntimeEnabledFeatures.in.

[commit-bot: I haz the power, 2016-11-08 03:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 03:31:15]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-08 03:31:48]

lgtm

[yhirano, 2016-11-08 03:47:55]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-08 03:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/2467233002/#ps180001
(title: "fix")

[commit-bot: I haz the power, 2016-11-08 03:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 04:01:18]

Description was changed from

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951



BUG=659965
==========

to

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951



BUG=659965
==========

[commit-bot: I haz the power, 2016-11-08 04:01:20]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-11-08 04:05:08]

Description was changed from

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951



BUG=659965
==========

to

==========
Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951

BUG=659965

Committed: https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313
Cr-Commit-Position: refs/heads/master@{#430513}
==========

[commit-bot: I haz the power, 2016-11-08 04:05:10]

Patchset 9 (id:??) landed as
https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313
Cr-Commit-Position: refs/heads/master@{#430513}