Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 246723006: Flush Xlib output buffer after calling XUngrabServer (Closed)

Created:
6 years, 8 months ago by Daniel Kurtz
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, dbehr, marcheu, oshima
Visibility:
Public.

Description

Flush Xlib output buffer after calling XUngrabServer One of the horrors of using Xlib is its Output buffer. When calling Xlib functions, the X command bitstream is not actually sent right away. Commands are first queued up in the Xlib output buffer, and only sent over the wire when the output buffer is flushed. X clients typically don't have to worry about this, since (a) commands that require return a response are flushed immediately, and (b) they usually have an event loop that calls XPending() (XNextEvent(), or XWindowEvent()), which does a Flush internally. Chrome, however, listens to the Xserver fd, and only enters its XPending() loop if the File Can be Read Without Blocking. The quick and dirty fix is to just send an explicit XFlush() after XUngrabServer(). Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>; BUG=chromium:366125 TEST=tbd R=msw@chromium.org R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Daniel Kurtz
6 years, 8 months ago (2014-04-23 16:18:44 UTC) #1
msw
lgtm. Thanks for fixing this here and elsewhere.
6 years, 8 months ago (2014-04-23 17:18:39 UTC) #2
Elliot Glaysher
lgtm (Should this also be fixed in u/v/w/d/x11_scoped_capture.cc?)
6 years, 8 months ago (2014-04-23 17:32:27 UTC) #3
Elliot Glaysher
On 2014/04/23 17:32:27, Elliot Glaysher wrote: > lgtm > > (Should this also be fixed ...
6 years, 8 months ago (2014-04-23 17:33:12 UTC) #4
Daniel Kurtz
On 2014/04/23 17:33:12, Elliot Glaysher wrote: > On 2014/04/23 17:32:27, Elliot Glaysher wrote: > > ...
6 years, 8 months ago (2014-04-26 01:41:25 UTC) #5
marcheu
The CQ bit was checked by marcheu@chromium.org
6 years, 8 months ago (2014-04-26 01:46:00 UTC) #6
Daniel Kurtz
The CQ bit was checked by djkurtz@chromium.org
6 years, 8 months ago (2014-04-26 02:04:26 UTC) #7
Daniel Kurtz
The CQ bit was unchecked by djkurtz@chromium.org
6 years, 8 months ago (2014-04-26 02:04:26 UTC) #8
Daniel Kurtz
The CQ bit was checked by djkurtz@chromium.org
6 years, 8 months ago (2014-04-26 02:04:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djkurtz@chromium.org/246723006/1
6 years, 8 months ago (2014-04-26 02:04:37 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 06:57:23 UTC) #11
Message was sent while issue was closed.
Change committed as 266455

Powered by Google App Engine
This is Rietveld 408576698