[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/0101f681f950a25b6708f522e24bdbd30ca50934
Cr-Commit-Position: refs/heads/master@{#431044}

[chanpatorikku, 2016-11-03 03:58:30]

Description was changed from

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-03 03:58:30]

chanpatorikku@gmail.com changed reviewers:
+ binji@chromium.org, sbc@chromium.org

[chanpatorikku, 2016-11-03 13:42:16]

Just in case you may wonder why I did not ask for a review yesterday while every
day I ask for one, something was not smooth yesterday.  Please ignore.

ptal.

[chanpatorikku, 2016-11-04 13:58:16]

The review looks to head to double the review time.  Risky if the review time is
shortened on codes with double the normal volume, though.

If I may help anything about reviewing the code, please let me know.

[binji, 2016-11-04 19:09:25]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[binji, 2016-11-04 19:09:43]

lgtm % trybots

[commit-bot: I haz the power, 2016-11-04 19:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:14:09]

Dry run: Try jobs failed on following builders:
  linux_nacl_sdk on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_nacl_sdk/...)

[binji, 2016-11-04 20:37:27]

On 2016/11/04 19:09:43, binji wrote:
> lgtm % trybots

Looks like there are some compile errors:

fake_ppapi/fake_node.cc: In member function ‘int32_t FakeNode::Read(int64_t,
char*, int32_t)’:
fake_ppapi/fake_node.cc:28: error: ‘memcpy’ was not declared in this scope
fake_ppapi/fake_node.cc: In member function ‘int32_t FakeNode::Write(int64_t,
const char*, int32_t)’:
fake_ppapi/fake_node.cc:42: error: ‘memcpy’ was not declared in this scope

[chanpatorikku, 2016-11-07 13:19:22]

The compile error appeared from the glibc toolchain.

The codes were tested in only pnacl toolchain > the compile error was not caught
before submitting patch set 1.  Incremental update of running test_sdk.py that
compiled and tested all glibc, pnacl, and clang-newlib can fix this problem.

ptal.

[chanpatorikku, 2016-11-09 13:18:56]

When you are not busy, ptal at the build.

[binji, 2016-11-09 20:04:08]

The CQ bit was checked by binji@chromium.org

[binji, 2016-11-09 20:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/2467223003/#ps20001
(title: "")

[commit-bot: I haz the power, 2016-11-09 20:04:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 21:57:56]

Description was changed from

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[commit-bot: I haz the power, 2016-11-09 21:57:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 22:02:22]

Description was changed from

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeHtml5FsFilesystem and FakeHtml5FsNode.

Move FakeHtml5FsFilesystem and FakeHtml5FsNode from
fake_pepper_interface_html5_fs.{cc,h} to
fake_filesystem.{cc,h} and fake_node.{cc,h} to share the code with the
future code.
depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and the code formats of some files were changed.
Refactor 2 classes but not 1 class because while refactoring
only FakeHtml5FsFilesystem, the files have a circular header reference.
Refactoring FakeHtml5FsFilesystem and FakeHtml5FsNode takes away
the circular header reference.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/0101f681f950a25b6708f522e24bdbd30ca50934
Cr-Commit-Position: refs/heads/master@{#431044}
==========

[commit-bot: I haz the power, 2016-11-09 22:02:23]

Patchset 2 (id:??) landed as
https://crrev.com/0101f681f950a25b6708f522e24bdbd30ca50934
Cr-Commit-Position: refs/heads/master@{#431044}