exo: Fix widget positioning for pop-ups

exo: Fix widget positioning for pop-ups

Since the initial bounds of a ShellSurface were relative to the root
window, pop-up windows (e.g. context menus in weston-terminal) whose
parents are on a secondary display would appear on the primary display.
In addition, the initial bounds were not taken into consideration when
updating the widget bounds.

BUG=631136
TEST=Drag weston-terminal to secondary display and right-click.
TEST=No regression for ARC windows.

Committed: https://crrev.com/24078fe2e32b15d2a2aacc9785f92d2c5da0d3c4
Cr-Commit-Position: refs/heads/master@{#429720}

[Dominik Laskowski, 2016-11-02 02:17:10]

domlaskowski@chromium.org changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[Dominik Laskowski, 2016-11-02 02:17:10]

Split from https://codereview.chromium.org/2396883003/

[Dominik Laskowski, 2016-11-02 02:17:18]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 02:17:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 02:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 02:44:29]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-11-02 14:24:19]

lg, would it be possible to add a simple ShellSurface unit test for this?

https://codereview.chromium.org/2467173002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2467173002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:1292: else {
nit: {} for the if-scope above too if needed for else-scope

[Dominik Laskowski, 2016-11-03 19:56:18]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[Dominik Laskowski, 2016-11-03 19:56:53]

Added a unit test.

https://codereview.chromium.org/2467173002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2467173002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:1292: else {
On 2016/11/02 14:24:19, reveman wrote:
> nit: {} for the if-scope above too if needed for else-scope

Done.

[commit-bot: I haz the power, 2016-11-03 19:57:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-11-03 20:17:37]

Thanks for the test. lgtm

[commit-bot: I haz the power, 2016-11-03 22:37:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:37:18]

Dry run: This issue passed the CQ dry run.

[Dominik Laskowski, 2016-11-03 22:39:50]

The CQ bit was checked by domlaskowski@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:12:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 23:15:02]

Description was changed from

==========
exo: Fix widget positioning for pop-ups

Since the initial bounds of a ShellSurface were relative to the root
window, pop-up windows (e.g. context menus in weston-terminal) whose
parents are on a secondary display would appear on the primary display.
In addition, the initial bounds were not taken into consideration when
updating the widget bounds.

BUG=631136
TEST=Drag weston-terminal to secondary display and right-click.
TEST=No regression for ARC windows.
==========

to

==========
exo: Fix widget positioning for pop-ups

Since the initial bounds of a ShellSurface were relative to the root
window, pop-up windows (e.g. context menus in weston-terminal) whose
parents are on a secondary display would appear on the primary display.
In addition, the initial bounds were not taken into consideration when
updating the widget bounds.

BUG=631136
TEST=Drag weston-terminal to secondary display and right-click.
TEST=No regression for ARC windows.

Committed: https://crrev.com/24078fe2e32b15d2a2aacc9785f92d2c5da0d3c4
Cr-Commit-Position: refs/heads/master@{#429720}
==========

[commit-bot: I haz the power, 2016-11-03 23:15:03]

Patchset 2 (id:??) landed as
https://crrev.com/24078fe2e32b15d2a2aacc9785f92d2c5da0d3c4
Cr-Commit-Position: refs/heads/master@{#429720}