Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2467133004: Correct net::EmbeddedTestServer usage in google_apis_unittests. (Closed)

Created:
4 years, 1 month ago by martijnc
Modified:
4 years, 1 month ago
Reviewers:
hidehiko
CC:
chromium-reviews, fukino+watch_chromium.org, oka+watch_chromium.org, yamaguchi+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding EmbeddedTestServer handlers after the server has started isn't thread safe. This CL updates a couple google_apis/drive/* tests to make EmbeddedTestServer thread safe. Either by starting the server after the handlers have been added or by only initializing the server before adding the handlers. BUG=546060 Committed: https://crrev.com/98e39c76641d4f66dcc1203fb19f8c7f248ee248 Cr-Commit-Position: refs/heads/master@{#429836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 1 month ago (2016-11-03 17:40:18 UTC) #3
hidehiko
Thank you for cleaning up. LGTM.
4 years, 1 month ago (2016-11-04 00:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467133004/1
4 years, 1 month ago (2016-11-04 08:42:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 08:55:11 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 08:59:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98e39c76641d4f66dcc1203fb19f8c7f248ee248
Cr-Commit-Position: refs/heads/master@{#429836}

Powered by Google App Engine
This is Rietveld 408576698