Settings: Internet: Update proxy controlled indicator and fields.

Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/afb75b2886338e87d1d81c2d3f12e26d2209adfb
Cr-Commit-Position: refs/heads/master@{#432668}

[stevenjb, 2016-11-02 01:14:27]

Description was changed from

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

BUG=658015
==========

to

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-11-02 01:15:53]

Description was changed from

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were
somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-11-02 01:16:29]

stevenjb@chromium.org changed reviewers:
+ emaxx@chromium.org, michaelpg@chromium.org

[stevenjb, 2016-11-02 01:16:30]

Also +emaxx@ FYI, feedback also welcome here.

[michaelpg, 2016-11-03 00:17:34]

lgtm w nit

You probably know, but other network JS files also still need translations (at
least network_siminfo.js and network_nameservers.js)

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1028: <message
name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_CONTROLLED_EXTENSION" desc="Settings >
Internet > Netwok details: Text to show when a network proxy is controlled by an
extension.">
https://memegen.googleplex.com/5899020588810240 here, above and below while
you're here

[emaxx, 2016-11-03 20:54:44]

lgtm (as far as I can understand the code, without having the general context
here)

[stevenjb, 2016-11-09 22:23:38]

PTAL

I added an indicator for extension enforced proxy settings based on the updated
version of the previous CL.

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1028: <message
name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_CONTROLLED_EXTENSION" desc="Settings >
Internet > Netwok details: Text to show when a network proxy is controlled by an
extension.">
On 2016/11/03 00:17:34, michaelpg (OOO) wrote:
> https://memegen.googleplex.com/5899020588810240 here, above and below while
> you're here

?

[michaelpg, 2016-11-12 00:22:23]

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1028: <message
name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_CONTROLLED_EXTENSION" desc="Settings >
Internet > Netwok details: Text to show when a network proxy is controlled by an
extension.">
On 2016/11/09 22:23:38, stevenjb wrote:
> On 2016/11/03 00:17:34, michaelpg (OOO) wrote:
> > https://memegen.googleplex.com/5899020588810240 here, above and below while
> > you're here
> 
> ?

I was suggesting you change the various instances of "Netwok" to "Network".

[stevenjb, 2016-11-12 00:24:42]

On 2016/11/12 00:22:23, michaelpg (OOO) wrote:
>
https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
> File chrome/app/settings_strings.grdp (right):
> 
>
https://codereview.chromium.org/2467123003/diff/1/chrome/app/settings_strings...
> chrome/app/settings_strings.grdp:1028: <message
> name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_CONTROLLED_EXTENSION" desc="Settings
>
> Internet > Netwok details: Text to show when a network proxy is controlled by
an
> extension.">
> On 2016/11/09 22:23:38, stevenjb wrote:
> > On 2016/11/03 00:17:34, michaelpg (OOO) wrote:
> > > https://memegen.googleplex.com/5899020588810240 here, above and below
while
> > > you're here
> > 
> > ?
> 
> I was suggesting you change the various instances of "Netwok" to "Network".

Thank you :) Done.

[stevenjb, 2016-11-16 21:37:36]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-11-16 21:37:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org, emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2467123003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-16 21:38:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 23:53:27]

Description was changed from

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were
somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were
somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-16 23:53:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 00:00:30]

Description was changed from

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were
somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Internet: Update proxy controlled indicator and fields.

This CL updates the proxy config indicators and shows the active
proxy configuration (which might be provided by an extension).

This also fixes some proxy strings that were not being translated and were
somehow previously missed.

BUG=658015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/afb75b2886338e87d1d81c2d3f12e26d2209adfb
Cr-Commit-Position: refs/heads/master@{#432668}
==========

[commit-bot: I haz the power, 2016-11-17 00:00:32]

Patchset 4 (id:??) landed as
https://crrev.com/afb75b2886338e87d1d81c2d3f12e26d2209adfb
Cr-Commit-Position: refs/heads/master@{#432668}