Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: tests/language/efficient_length_warning_test.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)
Patch Set: Fix a VM test that assumes too much about the object hierarchy. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/efficient_length_warning_test.dart
diff --git a/tests/language/efficient_length_warning_test.dart b/tests/language/efficient_length_warning_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..aebce61cbec164b33988c3e602b2a18fc511b389
--- /dev/null
+++ b/tests/language/efficient_length_warning_test.dart
@@ -0,0 +1,15 @@
+// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// Third dart test program.
+
+main(args) {
+ // This should no longer cause a warning because the least-upper-bound
+ // of List<int> and Set<int> is Object.
+ // The LUB is now EfficientLengthIterable and it extends Iterable.
+ var x = (args.length.isEven // Unpredictable condition.
+ ? <int>[1]
+ : new Set<int>.from([1])).first;
+ if (x != 1) throw "Wat?";
+}
+
« runtime/vm/debugger_api_impl_test.cc ('K') | « tests/corelib/growable_list_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698