Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/string_patch.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)
Patch Set: Fix a VM test that assumes too much about the object hierarchy. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/immutable_map.dart ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | runtime/vm/debugger_api_impl_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string_patch.dart
diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart
index 5abad6613e3e5064855f0a230fb915d404d87223..f046d8fd4e1c6c998c102cd62983b0d905bccde6 100644
--- a/runtime/lib/string_patch.dart
+++ b/runtime/lib/string_patch.dart
@@ -155,7 +155,7 @@ abstract class _StringBase {
static String _createStringFromIterable(Iterable<int> charCodes,
int start, int end) {
// Treat charCodes as Iterable.
- if (charCodes is EfficientLength) {
+ if (charCodes is EfficientLengthIterable) {
int length = charCodes.length;
end = RangeError.checkValidRange(start, end, length);
List charCodeList = new List.from(charCodes.take(end).skip(start),
« no previous file with comments | « runtime/lib/immutable_map.dart ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | runtime/vm/debugger_api_impl_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698