gl_context_glx: add workaround to create default context

gl_context_glx: add workaround to create default context

On old Mesa and hardware combos, creating the highest context version
possible leads to incorrect rendering in WebGL. Add a workaround to
fallback to creating a default context.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e8b4248621c4ed428eec4036f4918185cea23cd6
Cr-Commit-Position: refs/heads/master@{#429786}

[Corentin Wallez, 2016-11-02 18:22:23]

Description was changed from

==========
WIP

BUG=
==========

to

==========
WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-11-02 18:22:33]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 18:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 18:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:44:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Corentin Wallez, 2016-11-03 21:26:16]

Description was changed from

==========
WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gl_context_glx: add workaround to create default context

On old Mesa and hardware combos, creating the highest context version
possible leads to incorrect rendering in WebGL. Add a workaround to
fallback to creating a default context.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-11-03 21:26:17]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-11-03 21:26:21]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 21:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-11-03 21:30:02]

Needs a couple of small updates, but LGTM overall.

Thanks for your quick action on this!

https://codereview.chromium.org/2467103003/diff/50001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/content/browser/gpu/gpu...
content/browser/gpu/gpu_data_manager_impl_private.cc:749: if
(gpu_driver_bugs_.find(gpu::CREATE_DEFAULT_CONTEXT) !=
See below -- please rename to something like CREATE_DEFAULT_GL_CONTEXT here and
throughout.

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2204: "id": 202,
Need different ID.

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2206: "description": "Don't create
highest GL context possible on old Mesa / HW combos (intel part)",
(AMD part)

https://codereview.chromium.org/2467103003/diff/50001/ui/gl/gl_switches.cc
File ui/gl/gl_switches.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/ui/gl/gl_switches.cc#ne...
ui/gl/gl_switches.cc:31: const char kCreateDefaultContext[] =
"create-default-context";
Please name this something more specific to GL like create-default-gl-context.

[Corentin Wallez, 2016-11-03 21:41:45]

https://codereview.chromium.org/2467103003/diff/50001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/content/browser/gpu/gpu...
content/browser/gpu/gpu_data_manager_impl_private.cc:749: if
(gpu_driver_bugs_.find(gpu::CREATE_DEFAULT_CONTEXT) !=
On 2016/11/03 at 21:30:02, Ken Russell wrote:
> See below -- please rename to something like CREATE_DEFAULT_GL_CONTEXT here
and throughout.

Done

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2204: "id": 202,
On 2016/11/03 at 21:30:02, Ken Russell wrote:
> Need different ID.

Done

https://codereview.chromium.org/2467103003/diff/50001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2206: "description": "Don't create
highest GL context possible on old Mesa / HW combos (intel part)",
On 2016/11/03 at 21:30:02, Ken Russell wrote:
> (AMD part)

Done

https://codereview.chromium.org/2467103003/diff/50001/ui/gl/gl_switches.cc
File ui/gl/gl_switches.cc (right):

https://codereview.chromium.org/2467103003/diff/50001/ui/gl/gl_switches.cc#ne...
ui/gl/gl_switches.cc:31: const char kCreateDefaultContext[] =
"create-default-context";
On 2016/11/03 at 21:30:02, Ken Russell wrote:
> Please name this something more specific to GL like create-default-gl-context.

Done

[piman, 2016-11-03 21:45:20]

lgtm

[Corentin Wallez, 2016-11-03 21:48:26]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-11-03 21:48:27]

Thank you for the reviews

[Corentin Wallez, 2016-11-03 21:48:27]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2467103003/#ps70001
(title: "Address comments")

[commit-bot: I haz the power, 2016-11-03 21:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:22:05]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhenyao Mo, 2016-11-04 03:19:26]

On 2016/11/03 23:22:05, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

lgtm

[Zhenyao Mo, 2016-11-04 03:19:30]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:00:24]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-11-04 05:04:13]

Description was changed from

==========
gl_context_glx: add workaround to create default context

On old Mesa and hardware combos, creating the highest context version
possible leads to incorrect rendering in WebGL. Add a workaround to
fallback to creating a default context.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gl_context_glx: add workaround to create default context

On old Mesa and hardware combos, creating the highest context version
possible leads to incorrect rendering in WebGL. Add a workaround to
fallback to creating a default context.

BUG=659030
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e8b4248621c4ed428eec4036f4918185cea23cd6
Cr-Commit-Position: refs/heads/master@{#429786}
==========

[commit-bot: I haz the power, 2016-11-04 05:04:14]

Patchset 5 (id:??) landed as
https://crrev.com/e8b4248621c4ed428eec4036f4918185cea23cd6
Cr-Commit-Position: refs/heads/master@{#429786}