src/factory.cc - Issue 2467073002: Revert "Create internal fields on global proxy objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2467073002: Revert "Create internal fields on global proxy objects" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 749188f6bf27fc514b196624e82cf0e5d74a36ab..463603074499ee284b101c16dbdbb5965e56ef89 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2182,8 +2182,7 @@ Handle<JSProxy> Factory::NewJSProxy(Handle<JSReceiver> target,

Handle<JSGlobalProxy> Factory::NewUninitializedJSGlobalProxy() {

// Create an empty shell of a JSGlobalProxy that needs to be reinitialized

// via ReinitializeJSGlobalProxy later.

- Handle<Map> map =

- NewMap(JS_GLOBAL_PROXY_TYPE, JSGlobalProxy::kSizeWithInternalFields);

+ Handle<Map> map = NewMap(JS_GLOBAL_PROXY_TYPE, JSGlobalProxy::kSize);

// Maintain invariant expected from any JSGlobalProxy.

map->set_is_access_check_needed(true);

CALL_HEAP_FUNCTION(

« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects.h » ('j') | no next file with comments »