Move FF and Canary to green on travis

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],
-      function(dart_sdk, async_helper, expect, unittest, require) {
+define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
+      function(dart_sdk, async_helper, expect, unittest, is, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
 
   dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
   let html_config = unittest.html_config;
   // Test attributes are a list of strings, or a string for a single
   // attribute. Valid attributes are:
   //
+  //   'pass' - test passes (default)
   //   'skip' - don't run the test
   //   'fail' - test fails
   //   'timeout' - test times out
   //   'slow' - use 5s timeout instead of default 2s.
   //   'helper'  - not a test, used by other tests.
   //   'unittest' - run separately as a unittest test.
   //
   // Common combinations:
+  const pass = 'pass';
   const fail = 'fail';
   const skip_fail = ['skip', 'fail'];
   const skip_timeout = ['skip', 'timeout'];
 
+  // Browsers
+  const firefox_fail = is.firefox() ? fail : pass;
+  console.log(firefox_fail);

[Bob Nystrom, 2016/11/02 21:37:21]

Remove the log().

+
   // Tests marked with this are still using the deprecated unittest package
   // because they rely on its support for futures and asynchronous tests, which
   // expect and minitest do not handle.
   // TODO(rnystrom): Move all of these away from using the async test API so
   // they can stop using unittest.
   const async_unittest = ['unittest', 'skip', 'fail'];
 
   // The number of expected unittest errors should be zero but unfortunately
   // there are a lot of broken html unittests.
   let num_expected_unittest_fails = 3;
@@ skipping 211 matching lines @@
       'mixin_mixin7_test': skip_fail,
       'mixin_mixin_bound2_test': skip_fail,
       'mixin_mixin_bound_test': skip_fail,
       'mixin_mixin_test': skip_fail,
       'mixin_regress_13688_test': skip_fail,
       'mixin_type_parameter1_test': skip_fail,
       'mixin_type_parameter2_test': skip_fail,
       'mixin_type_parameter3_test': skip_fail,
       'modulo_test': fail,
       'named_parameter_clash_test': skip_fail,
+      'named_parameters_passing_falsy_test': firefox_fail,
       'nan_identical_test': skip_fail,
       'nested_switch_label_test': skip_fail,
       'number_identifier_test_05_multi': skip_fail,
       'number_identity2_test': skip_fail,
       'numbers_test': skip_fail,
       'optimized_hoisting_checked_mode_assert_test': skip_fail,
       'redirecting_factory_reflection_test': skip_fail,
       'regress_13462_0_test': skip_fail,
       'regress_13462_1_test': skip_fail,
       'regress_14105_test': skip_fail,
@@ skipping 13 matching lines @@
       'string_interpolate_null_test': skip_fail,
       'super_operator_index3_test': skip_fail,
       'super_operator_index4_test': skip_fail,
       'switch_label2_test': skip_fail,
       'switch_label_test': skip_fail,
       'switch_try_catch_test': skip_fail,
       'sync_generator1_test_none_multi': skip_fail,
       'throwing_lazy_variable_test': skip_fail,
       'top_level_non_prefixed_library_test': skip_fail,
       'truncdiv_test': fail,  // did not throw
+      'type_literal_test': firefox_fail,
       'type_variable_nested_test': skip_fail,  // unsound is-check
       'type_variable_typedef_test': skip_fail,  // unsound is-check
 
       'bit_operations_test_01_multi': skip_fail,
       'bit_operations_test_02_multi': skip_fail,
       'bit_operations_test_03_multi': skip_fail,
       'bit_operations_test_04_multi': skip_fail,
       'bool_condition_check_test_01_multi': skip_fail,
       'deferred_constraints_constants_test_none_multi': skip_fail,
       'deferred_constraints_constants_test_reference_after_load_multi': skip_fail,
@@ skipping 33 matching lines @@
       'big_integer_parsed_arith_vm_test': fail,
       'big_integer_parsed_div_rem_vm_test': fail,
       'big_integer_parsed_mul_div_vm_test': fail,
       'bit_twiddling_bigint_test': fail,
       'collection_length_test': skip_timeout,
       'compare_to2_test': fail,
       'const_list_literal_test': fail,
       'const_list_remove_range_test': fail,
       'const_list_set_range_test': fail,
       'double_parse_test_01_multi': fail,
+      'double_parse_test_02_multi': firefox_fail,
       'error_stack_trace1_test': fail,
       'error_stack_trace2_test': fail,
+      'for_in_test': firefox_fail,
       'hash_map2_test': skip_timeout,
       'hash_set_test_01_multi': fail,
       'hidden_library2_test_01_multi': fail,
       'indexed_list_access_test': fail,
       'int_modulo_arith_test_bignum_multi': fail,
       'int_modulo_arith_test_modPow_multi': fail,
       'int_modulo_arith_test_none_multi': fail,
       'int_parse_radix_test_01_multi': fail, // JS implementations disagree on U+0085 being whitespace.
       'int_parse_radix_test_02_multi': ['fail', 'timeout', 'skip'], // No bigints.
       'int_parse_radix_test_none_multi': ['slow'],
       'integer_to_radix_string_test': fail,
       'integer_to_string_test_01_multi': fail,
       'iterable_generate_test': fail,
       'iterable_return_type_test_02_multi': fail,
       'json_map_test': fail,
       'list_fill_range_test': fail,
       'list_replace_range_test': fail,
       'list_set_all_test': fail,
       'list_to_string2_test': fail,
       'main_test': fail,
       'map_keys2_test': fail,
       'map_to_string_test': fail,
+      'map_from_iterable_test': firefox_fail,
       'nan_infinity_test_01_multi': fail,
       'null_nosuchmethod_test': fail,
       'null_test': fail,
       'num_sign_test': fail,
       'regress_r21715_test': fail,
       'throw_half_surrogate_pair_test_02_multi': fail,
-      'stacktrace_current_test': fail,
+      'splay_tree_from_iterable_test': firefox_fail,
+      'stacktrace_current_test': is.chrome() ? fail : pass,

[Bob Nystrom, 2016/11/02 21:37:21]

Make a chrome_fail variable too?

+      'string_case_test_01_multi': firefox_fail,
       'string_fromcharcodes_test': skip_timeout,
       'string_operations_with_null_test': fail,
       'symbol_reserved_word_test_06_multi': fail,
       'symbol_reserved_word_test_09_multi': fail,
       'symbol_reserved_word_test_12_multi': fail,
       'throw_half_surrogate_pair_test_01_multi': fail,
+      'unicode_test': firefox_fail,
+      'uri_parameters_all_test': firefox_fail,
       // TODO(rnystrom): Times out because it tests a huge number of
       // combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
       'uri_parse_test': skip_timeout,
+      'uri_test': firefox_fail,
 
       'list_insert_test': fail,
       'list_removeat_test': fail,
       'set_test': fail, // runtime strong mode reject
     },
 
     'corelib/regexp': {
-      'default_arguments_test': fail
+      'default_arguments_test': fail,
+      'UC16_test': firefox_fail,
+      'unicodeCaseInsensitive_test': firefox_fail
     },
 
     'lib/convert': {
       'encoding_test': skip_timeout,
 
       // TODO(jmesserly): this is in an inconsistent state between our old and
       // newer SDKs.
       'html_escape_test': ['skip'],
 
       'json_utf8_chunk_test': skip_timeout,
       'latin1_test': skip_timeout,
 
       'streamed_conversion_json_encode1_test': skip_timeout,
       'streamed_conversion_json_utf8_decode_test': skip_timeout,
       'streamed_conversion_json_utf8_encode_test': skip_timeout,
       'streamed_conversion_utf8_decode_test': skip_timeout,
       'streamed_conversion_utf8_encode_test': skip_timeout,
       'utf85_test': skip_timeout,
     },
 
     'lib/html': {
       'async_spawnuri_test': async_unittest,
       'async_test': async_unittest,
-      'audiocontext_test': 'fail', // was sdk#27578, needs triage
+      'audiocontext_test': is.chrome('<=55') ? fail : pass, // was sdk#27578, needs triage
       'blob_constructor_test': 'fail', // was sdk#27578, needs triage
       'canvas_test': ['unittest'],
       'canvasrenderingcontext2d_test': ['unittest'],
       'cross_domain_iframe_test': async_unittest,
       'cssstyledeclaration_test': async_unittest,
       'css_test': async_unittest,
 
       // This is failing with a range error, I'm guessing because it's looking
       // for a stylesheet and the page has none.
       'css_rule_list_test': 'fail',
       'custom_element_method_clash_test': async_unittest,
       'custom_element_name_clash_test': async_unittest,
       'custom_elements_23127_test': async_unittest,
       'custom_elements_test': async_unittest,
       'dom_constructors_test': 'fail', // was sdk#27578, needs triage
       'element_animate_test': async_unittest,
       'element_classes_test': 'fail', // sdk#27579.
       'element_classes_svg_test': 'fail', // sdk#27579.
 
       // Failure: 'Expected 56 to be in the inclusive range [111, 160].'.
       'element_offset_test': 'fail',
       'element_test': async_unittest,
+      'element_types_test': firefox_fail,
       'event_customevent_test': async_unittest,
       'events_test': async_unittest,
 
       // Failure: "Failed to execute 'dispatchEvent' on 'EventTarget': parameter
       // 1 is not of type 'Event'."
       'event_test': 'fail',
       'fileapi_test': async_unittest,
       'filereader_test': async_unittest,
       'fontface_loaded_test': async_unittest,
 
@@ skipping 27 matching lines @@
 
       // Should throw but does not.
       'mirrors_js_typed_interop_test': 'fail',
 
       'mutationobserver_test': async_unittest,
       'native_gc_test': async_unittest,
       'notification_test': 'fail', // was sdk#27578, needs triage
       'postmessage_structured_test': async_unittest,
       'request_animation_frame_test': async_unittest,
       'resource_http_test': async_unittest,
-      'rtc_test': 'fail', // was sdk#27578, needs triage
+      'rtc_test': is.chrome('<=55') ? fail : pass, // was sdk#27578, needs triage
 
       // Expected 1, got null.
       'serialized_script_value_test': 'fail',
+      'shadow_dom_test': firefox_fail,
       'speechrecognition_test': 'fail', // was sdk#27578, needs triage
-      'svgelement_test': 'fail', // was sdk#27578, needs triage
+      'svgelement_test': is.chrome() ? fail : pass, // was sdk#27578, needs triage
+      'text_event_test': firefox_fail,
       'touchevent_test': 'fail', // was sdk#27578, needs triage
       'transferables_test': async_unittest,
       'transition_event_test': async_unittest,
       'url_test': async_unittest,
       'websocket_test': async_unittest,
       'websql_test': async_unittest,
       'wheelevent_test': async_unittest,
       'worker_api_test': async_unittest,
       'worker_test': async_unittest,
 
@@ skipping 155 matching lines @@
       'to_string_test': fail,
       'type_argument_is_type_variable_test': fail,
       'type_variable_is_static_test': fail,
       'type_variable_owner_test_01_multi': fail,
       'type_variable_owner_test_none_multi': fail,
       'typedef_deferred_library_test': skip_fail,  // Isolate spawn not support
       'typedef_library_test': fail,
       'typedef_metadata_test': fail,
       'typedef_test': fail,
       'typevariable_mirror_metadata_test': fail,
+      'unmangled_type_test': firefox_fail,
       'unnamed_library_test': fail,
       'variable_is_const_test_none_multi': fail,
     },
   };
 
   function countMatches(text, regex) {
     let matches = text.match(regex);
     return matches ? matches.length : 0;
   }
   function libraryName(name) {
@@ skipping 151 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });