Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2467053002: Revert of Linux Aura: Make tab dragging great again (Closed)

Created:
4 years, 1 month ago by Tom Anderson
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tfarina, sadrul, derat+watch_chromium.org, dcheng, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux Aura: Make tab dragging great again (patchset #4 id:60001 of https://codereview.chromium.org/2410773002/ ) Reason for revert: Suspecting this is causing 661248, so conservatively reverting. Original issue's description: > Linux Aura: Make tab dragging great again > > This CL uses _NET_WM_MOVERESIZE to handle tab dragging for managed windows on > select window managers. > > This fixes various issues I've seen with tab dragging including: > * Window movement is no longer constrained by screen bounds > * Windows animating in during tab dragging is minimized > * Tab dragging is improved on tiling WMs > * Better integration with desktop environment (you can now drag to the top of > the screen to maximize if the DE supports it, or drag left/right between > workspaces) > > BUG=416119, 617806, 635195 > R=erg@chromium.org,sky@chromium.org > > Committed: https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724 > Cr-Commit-Position: refs/heads/master@{#424909} TBR=erg@chromium.org,sky@chromium.org,derat@chromium.org,thomasanderson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=416119, 617806, 635195 BUG=661248 Committed: https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3 Cr-Commit-Position: refs/heads/master@{#429093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -332 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 3 chunks +1 line, -9 lines 0 comments Download
M ui/base/x/x11_util.h View 2 chunks +0 lines, -23 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 4 chunks +2 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 5 chunks +47 lines, -74 lines 0 comments Download
D ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 5 chunks +51 lines, -14 lines 0 comments Download
M ui/wm/public/window_move_client.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Anderson
Created Revert of Linux Aura: Make tab dragging great again
4 years, 1 month ago (2016-11-01 19:32:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467053002/1
4 years, 1 month ago (2016-11-01 19:33:27 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 20:36:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3
Cr-Commit-Position: refs/heads/master@{#429093}

Powered by Google App Engine
This is Rietveld 408576698