Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: ui/events/blink/input_handler_proxy.cc

Issue 2467023003: Revert "Touchpad scroll latching enabled for Mac behind flag." (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/blink/input_handler_proxy.h" 5 #include "ui/events/blink/input_handler_proxy.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 return scroll_begin_event; 126 return scroll_begin_event;
127 } 127 }
128 128
129 cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) { 129 cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) {
130 cc::ScrollStateData scroll_state_data; 130 cc::ScrollStateData scroll_state_data;
131 switch (event.type) { 131 switch (event.type) {
132 case WebInputEvent::GestureScrollBegin: 132 case WebInputEvent::GestureScrollBegin:
133 scroll_state_data.position_x = event.x; 133 scroll_state_data.position_x = event.x;
134 scroll_state_data.position_y = event.y; 134 scroll_state_data.position_y = event.y;
135 scroll_state_data.is_beginning = true; 135 scroll_state_data.is_beginning = true;
136 // On Mac, a GestureScrollBegin in the inertial phase indicates a fling
137 // start.
138 if (event.data.scrollBegin.inertialPhase ==
139 WebGestureEvent::MomentumPhase) {
140 scroll_state_data.is_in_inertial_phase = true;
141 }
142 break; 136 break;
143 case WebInputEvent::GestureFlingStart: 137 case WebInputEvent::GestureFlingStart:
144 scroll_state_data.velocity_x = event.data.flingStart.velocityX; 138 scroll_state_data.velocity_x = event.data.flingStart.velocityX;
145 scroll_state_data.velocity_y = event.data.flingStart.velocityY; 139 scroll_state_data.velocity_y = event.data.flingStart.velocityY;
146 scroll_state_data.is_in_inertial_phase = true; 140 scroll_state_data.is_in_inertial_phase = true;
147 break; 141 break;
148 case WebInputEvent::GestureScrollUpdate: 142 case WebInputEvent::GestureScrollUpdate:
149 scroll_state_data.delta_x = -event.data.scrollUpdate.deltaX; 143 scroll_state_data.delta_x = -event.data.scrollUpdate.deltaX;
150 scroll_state_data.delta_y = -event.data.scrollUpdate.deltaY; 144 scroll_state_data.delta_y = -event.data.scrollUpdate.deltaY;
151 scroll_state_data.velocity_x = event.data.scrollUpdate.velocityX; 145 scroll_state_data.velocity_x = event.data.scrollUpdate.velocityX;
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 ? -wheel_event.deltaY 523 ? -wheel_event.deltaY
530 : 0); 524 : 0);
531 525
532 if (wheel_event.scrollByPage) { 526 if (wheel_event.scrollByPage) {
533 // TODO(jamesr): We don't properly handle scroll by page in the compositor 527 // TODO(jamesr): We don't properly handle scroll by page in the compositor
534 // thread, so punt it to the main thread. http://crbug.com/236639 528 // thread, so punt it to the main thread. http://crbug.com/236639
535 RecordMainThreadScrollingReasons( 529 RecordMainThreadScrollingReasons(
536 blink::WebGestureDeviceTouchpad, 530 blink::WebGestureDeviceTouchpad,
537 cc::MainThreadScrollingReason::kPageBasedScrolling); 531 cc::MainThreadScrollingReason::kPageBasedScrolling);
538 return DID_NOT_HANDLE; 532 return DID_NOT_HANDLE;
533
534 } else if (ShouldAnimate(wheel_event.hasPreciseScrollingDeltas)) {
535 base::TimeTicks event_time =
536 base::TimeTicks() +
537 base::TimeDelta::FromSecondsD(wheel_event.timeStampSeconds);
538 base::TimeDelta delay = base::TimeTicks::Now() - event_time;
539 cc::InputHandler::ScrollStatus scroll_status =
540 input_handler_->ScrollAnimated(gfx::Point(wheel_event.x, wheel_event.y),
541 scroll_delta, delay);
542
543 RecordMainThreadScrollingReasons(
544 blink::WebGestureDeviceTouchpad,
545 scroll_status.main_thread_scrolling_reasons);
546
547 switch (scroll_status.thread) {
548 case cc::InputHandler::SCROLL_ON_IMPL_THREAD:
549 return DID_HANDLE;
550 case cc::InputHandler::SCROLL_IGNORED:
551 return DROP_EVENT;
552 default:
553 return DID_NOT_HANDLE;
554 }
555
539 } else { 556 } else {
540 DCHECK(!ShouldAnimate(wheel_event.hasPreciseScrollingDeltas));
541 cc::ScrollStateData scroll_state_begin_data; 557 cc::ScrollStateData scroll_state_begin_data;
542 scroll_state_begin_data.position_x = wheel_event.x; 558 scroll_state_begin_data.position_x = wheel_event.x;
543 scroll_state_begin_data.position_y = wheel_event.y; 559 scroll_state_begin_data.position_y = wheel_event.y;
544 scroll_state_begin_data.is_beginning = true; 560 scroll_state_begin_data.is_beginning = true;
545 cc::ScrollState scroll_state_begin(scroll_state_begin_data); 561 cc::ScrollState scroll_state_begin(scroll_state_begin_data);
546 cc::InputHandler::ScrollStatus scroll_status = input_handler_->ScrollBegin( 562 cc::InputHandler::ScrollStatus scroll_status = input_handler_->ScrollBegin(
547 &scroll_state_begin, cc::InputHandler::WHEEL); 563 &scroll_state_begin, cc::InputHandler::WHEEL);
548 564
549 RecordMainThreadScrollingReasons( 565 RecordMainThreadScrollingReasons(
550 blink::WebGestureDeviceTouchpad, 566 blink::WebGestureDeviceTouchpad,
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 if (!gesture_scroll_on_impl_thread_ && !gesture_pinch_on_impl_thread_) 681 if (!gesture_scroll_on_impl_thread_ && !gesture_pinch_on_impl_thread_)
666 return DID_NOT_HANDLE; 682 return DID_NOT_HANDLE;
667 683
668 cc::ScrollState scroll_state = CreateScrollStateForGesture(gesture_event); 684 cc::ScrollState scroll_state = CreateScrollStateForGesture(gesture_event);
669 gfx::Point scroll_point(gesture_event.x, gesture_event.y); 685 gfx::Point scroll_point(gesture_event.x, gesture_event.y);
670 gfx::Vector2dF scroll_delta(-gesture_event.data.scrollUpdate.deltaX, 686 gfx::Vector2dF scroll_delta(-gesture_event.data.scrollUpdate.deltaX,
671 -gesture_event.data.scrollUpdate.deltaY); 687 -gesture_event.data.scrollUpdate.deltaY);
672 688
673 if (ShouldAnimate(gesture_event.data.scrollUpdate.deltaUnits != 689 if (ShouldAnimate(gesture_event.data.scrollUpdate.deltaUnits !=
674 blink::WebGestureEvent::ScrollUnits::Pixels)) { 690 blink::WebGestureEvent::ScrollUnits::Pixels)) {
675 DCHECK(!scroll_state.is_in_inertial_phase());
676 base::TimeTicks event_time = 691 base::TimeTicks event_time =
677 base::TimeTicks() + 692 base::TimeTicks() +
678 base::TimeDelta::FromSecondsD(gesture_event.timeStampSeconds); 693 base::TimeDelta::FromSecondsD(gesture_event.timeStampSeconds);
679 base::TimeDelta delay = base::TimeTicks::Now() - event_time; 694 base::TimeDelta delay = base::TimeTicks::Now() - event_time;
680 switch (input_handler_->ScrollAnimated(scroll_point, scroll_delta, delay) 695 switch (input_handler_->ScrollAnimated(scroll_point, scroll_delta, delay)
681 .thread) { 696 .thread) {
682 case cc::InputHandler::SCROLL_ON_IMPL_THREAD: 697 case cc::InputHandler::SCROLL_ON_IMPL_THREAD:
683 return DID_HANDLE; 698 return DID_HANDLE;
684 case cc::InputHandler::SCROLL_IGNORED: 699 case cc::InputHandler::SCROLL_IGNORED:
685 return DROP_EVENT; 700 return DROP_EVENT;
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 // is made asynchronously, to minimize divergence between main thread and 1411 // is made asynchronously, to minimize divergence between main thread and
1397 // impl thread event handling paths. 1412 // impl thread event handling paths.
1398 base::ThreadTaskRunnerHandle::Get()->PostTask( 1413 base::ThreadTaskRunnerHandle::Get()->PostTask(
1399 FROM_HERE, 1414 FROM_HERE,
1400 base::Bind(&InputScrollElasticityController::ObserveGestureEventAndResult, 1415 base::Bind(&InputScrollElasticityController::ObserveGestureEventAndResult,
1401 scroll_elasticity_controller_->GetWeakPtr(), gesture_event, 1416 scroll_elasticity_controller_->GetWeakPtr(), gesture_event,
1402 scroll_result)); 1417 scroll_result));
1403 } 1418 }
1404 1419
1405 } // namespace ui 1420 } // namespace ui
OLDNEW
« no previous file with comments | « content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698