Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2466993005: [CUPS] Fix the occasional crash when switching between different dialogs. (Closed)

Created:
4 years, 1 month ago by xdai1
Modified:
4 years, 1 month ago
Reviewers:
skau
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Fix the occasional crash when switching between different dialogs. We had some feedback from the testing team: Chrome crashes something - typically when switching between the printer discovery dialog and the manually add printer dialog. BUG=662077, 626752 Committed: https://crrev.com/e199cde96ef5e0f486624339b41cc72f3e3793ec Cr-Commit-Position: refs/heads/master@{#429648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chromeos/printing/fake_printer_discoverer.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/printing/fake_printer_discoverer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/printing/printer_discoverer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
xdai1
skau@, could you help review this CL please? Thanks!
4 years, 1 month ago (2016-11-03 17:21:26 UTC) #2
skau
lgtm Thanks for the fix. I would not have thought this was the cause of ...
4 years, 1 month ago (2016-11-03 17:53:54 UTC) #5
skau
lgtm Thanks for the fix. I would not have thought this was the cause of ...
4 years, 1 month ago (2016-11-03 17:53:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466993005/1
4 years, 1 month ago (2016-11-03 17:59:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 18:07:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:14:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e199cde96ef5e0f486624339b41cc72f3e3793ec
Cr-Commit-Position: refs/heads/master@{#429648}

Powered by Google App Engine
This is Rietveld 408576698