Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: mojo/edk/system/ports/ports_unittest.cc

Issue 2466993004: Remove use of std::function from Mojo internals (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/ports/node.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/ports/ports_unittest.cc
diff --git a/mojo/edk/system/ports/ports_unittest.cc b/mojo/edk/system/ports/ports_unittest.cc
index b76fa10de5fbb19a5c87278f3cdedfca541c429b..cb48b3eb2f4100ac901db4fead045c2591ba8f9d 100644
--- a/mojo/edk/system/ports/ports_unittest.cc
+++ b/mojo/edk/system/ports/ports_unittest.cc
@@ -172,7 +172,7 @@ class TestNode : public NodeDelegate {
}
bool ReadMessage(const PortRef& port, ScopedMessage* message) {
- return node_.GetMessage(port, message) == OK && *message;
+ return node_.GetMessage(port, message, nullptr) == OK && *message;
}
bool GetSavedMessage(ScopedMessage* message) {
@@ -581,14 +581,15 @@ TEST_F(PortsTest, LostConnectionToNode2) {
// a0 should have eventually detected peer closure after node loss.
ScopedMessage message;
- EXPECT_EQ(ERROR_PORT_PEER_CLOSED, node0.node().GetMessage(a0, &message));
+ EXPECT_EQ(ERROR_PORT_PEER_CLOSED,
+ node0.node().GetMessage(a0, &message, nullptr));
EXPECT_FALSE(message);
EXPECT_EQ(OK, node0.node().ClosePort(a0));
EXPECT_EQ(OK, node0.node().ClosePort(x0));
- EXPECT_EQ(OK, node1.node().GetMessage(x1, &message));
+ EXPECT_EQ(OK, node1.node().GetMessage(x1, &message, nullptr));
EXPECT_TRUE(message);
node1.ClosePortsInMessage(message.get());
@@ -725,14 +726,15 @@ TEST_F(PortsTest, GetMessage1) {
EXPECT_EQ(OK, node.node().CreatePortPair(&a0, &a1));
ScopedMessage message;
- EXPECT_EQ(OK, node.node().GetMessage(a0, &message));
+ EXPECT_EQ(OK, node.node().GetMessage(a0, &message, nullptr));
EXPECT_FALSE(message);
EXPECT_EQ(OK, node.node().ClosePort(a1));
WaitForIdle();
- EXPECT_EQ(ERROR_PORT_PEER_CLOSED, node.node().GetMessage(a0, &message));
+ EXPECT_EQ(ERROR_PORT_PEER_CLOSED,
+ node.node().GetMessage(a0, &message, nullptr));
EXPECT_FALSE(message);
EXPECT_EQ(OK, node.node().ClosePort(a0));
@@ -752,7 +754,7 @@ TEST_F(PortsTest, GetMessage2) {
EXPECT_EQ(OK, node.SendStringMessage(a1, "1"));
ScopedMessage message;
- EXPECT_EQ(OK, node.node().GetMessage(a0, &message));
+ EXPECT_EQ(OK, node.node().GetMessage(a0, &message, nullptr));
ASSERT_TRUE(message);
EXPECT_TRUE(MessageEquals(message, "1"));
@@ -781,7 +783,7 @@ TEST_F(PortsTest, GetMessage3) {
ScopedMessage message;
for (size_t i = 0; i < sizeof(kStrings)/sizeof(kStrings[0]); ++i) {
- EXPECT_EQ(OK, node.node().GetMessage(a0, &message));
+ EXPECT_EQ(OK, node.node().GetMessage(a0, &message, nullptr));
ASSERT_TRUE(message);
EXPECT_TRUE(MessageEquals(message, kStrings[i]));
}
« no previous file with comments | « mojo/edk/system/ports/node.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698