Remove use of std::function from Mojo internals

Remove use of std::function from Mojo internals

Introduces a ports::MessageFilter type for filtering messages
on a port's queue. This should be slightly more efficient since it
avoids a heap allocation, and it should lead to more useful stack
traces in certain crash reports.

BUG=609030
R=yzshen@chromium.org

Committed: https://crrev.com/03e91a8a23d50943760df3c84a5439fbbc2c0e59
Cr-Commit-Position: refs/heads/master@{#429524}

[Ken Rockot(use gerrit already), 2016-11-02 21:04:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 21:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-02 21:05:42]

Description was changed from

==========
Remove use of std::function from the EDK

Introduces a ports::MessageFilter type for filtering messages
on a port's queue. This should be slightly more efficient since it
avoids a heap allocation, and it should lead to more useful stack
traces in certain crash reports.

BUG=609030
R=yzshen@chromium.org
==========

to

==========
Remove use of std::function from Mojo internals

Introduces a ports::MessageFilter type for filtering messages
on a port's queue. This should be slightly more efficient since it
avoids a heap allocation, and it should lead to more useful stack
traces in certain crash reports.

BUG=609030
R=yzshen@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-11-02 21:06:32]

Please take a look. Thanks!

[commit-bot: I haz the power, 2016-11-02 22:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:30:38]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-11-03 00:11:27]

LGTM

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
File mojo/edk/system/message_pipe_dispatcher.cc (right):

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
mojo/edk/system/message_pipe_dispatcher.cc:130: bool* invalid_message_;
 nit: now that the other pointers are made const, maybe we could also make this
one const?

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
mojo/edk/system/message_pipe_dispatcher.cc:589: PeekSizeMessageFilter
filter(&message_size);
Does it make sense to make message_size a member of PeekSizeMessageFilter
directly?

[Ken Rockot(use gerrit already), 2016-11-03 00:44:38]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-03 01:25:08]

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
File mojo/edk/system/message_pipe_dispatcher.cc (right):

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
mojo/edk/system/message_pipe_dispatcher.cc:130: bool* invalid_message_;
On 2016/11/03 at 00:11:27, yzshen1 wrote:
> nit: now that the other pointers are made const, maybe we could also make this
one const?

done

https://codereview.chromium.org/2466993004/diff/1/mojo/edk/system/message_pip...
mojo/edk/system/message_pipe_dispatcher.cc:589: PeekSizeMessageFilter
filter(&message_size);
On 2016/11/03 at 00:11:27, yzshen1 wrote:
> Does it make sense to make message_size a member of PeekSizeMessageFilter
directly?

done

[Ken Rockot(use gerrit already), 2016-11-03 01:25:22]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-03 01:25:30]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-03 01:25:31]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2466993004/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-11-03 01:25:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 03:01:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 03:01:21]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2016-11-03 03:46:40]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-11-03 03:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 04:24:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 04:27:06]

Description was changed from

==========
Remove use of std::function from Mojo internals

Introduces a ports::MessageFilter type for filtering messages
on a port's queue. This should be slightly more efficient since it
avoids a heap allocation, and it should lead to more useful stack
traces in certain crash reports.

BUG=609030
R=yzshen@chromium.org
==========

to

==========
Remove use of std::function from Mojo internals

Introduces a ports::MessageFilter type for filtering messages
on a port's queue. This should be slightly more efficient since it
avoids a heap allocation, and it should lead to more useful stack
traces in certain crash reports.

BUG=609030
R=yzshen@chromium.org

Committed: https://crrev.com/03e91a8a23d50943760df3c84a5439fbbc2c0e59
Cr-Commit-Position: refs/heads/master@{#429524}
==========

[commit-bot: I haz the power, 2016-11-03 04:27:07]

Patchset 2 (id:??) landed as
https://crrev.com/03e91a8a23d50943760df3c84a5439fbbc2c0e59
Cr-Commit-Position: refs/heads/master@{#429524}