Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2466933003: Revert of Convert Site Isolation Win bot to --isolate-extensions. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis, alexmos, nasko
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert Site Isolation Win bot to --isolate-extensions. (patchset #2 id:20001 of https://codereview.chromium.org/2459813003/ ) Reason for revert: This CL is the most likely cause of linux_site_isolation purpleness (https://crbug.com/661447). Original issue's description: > Convert Site Isolation Win bot to --isolate-extensions. > > The --isolate-extension feature is not enabled by default for now, so > convert the bot to ensure we have test coverage for it. > > BUG=545200 > > Committed: https://crrev.com/500b39f98671c820f3a519b30e49e0d6e860dc64 > Cr-Commit-Position: refs/heads/master@{#428848} TBR=alexmos@chromium.org,creis@chromium.org,nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=545200 Committed: https://crrev.com/f1fd37d16b103525d36ec8b7aa261a51ce8f6f22 Cr-Commit-Position: refs/heads/master@{#429296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M testing/buildbot/chromium.fyi.json View 13 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Łukasz Anforowicz
Created Revert of Convert Site Isolation Win bot to --isolate-extensions.
4 years, 1 month ago (2016-11-02 15:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466933003/1
4 years, 1 month ago (2016-11-02 15:17:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 16:26:04 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:51:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1fd37d16b103525d36ec8b7aa261a51ce8f6f22
Cr-Commit-Position: refs/heads/master@{#429296}

Powered by Google App Engine
This is Rietveld 408576698