Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 246693005: Convert function.prototype to API-style accessor. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Convert function.prototype to API-style accessor. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20926

Patch Set 1 #

Patch Set 2 : Check that exception is never thrown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -54 lines) Patch
M src/accessors.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/accessors.cc View 1 3 chunks +39 lines, -35 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 8 months ago (2014-04-23 13:29:56 UTC) #1
Yang
On 2014/04/23 13:29:56, ulan wrote: > PTAL LGTM. Please make sure that we do have ...
6 years, 8 months ago (2014-04-23 13:36:01 UTC) #2
ulan
6 years, 8 months ago (2014-04-24 08:36:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698